Attachment 595172 Details for Bug 828993 – fedora-review for l3afpad

fedora-review for l3afpad

l3afpad-review.txt (text/plain), 5.08 KB, created by John Morris on 2012-06-29 04:01:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John Morris

Created: 2012-06-29 04:01:10 UTC

Size: 5.08 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass (script)
>X = Pass (manually checked)
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[X]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[X]: MUST Package contains no bundled libraries.
>[X]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[X]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[X]: MUST Macros in Summary, %description expandable at SRPM build time.
>[X]: MUST Package requires other packages for directories it uses.
>[X]: MUST Package uses nothing in %doc for runtime.
>[X]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[X]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[X]: MUST Large documentation files are in a -doc subpackage, if required.
>[X]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[X]: MUST License field in the package spec file matches the actual license.
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[ ]: MUST Package does not generate any conflict.
>[X]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[X]: MUST Package must own all directories that it creates.
>[X]: MUST Package installs properly.
>[X]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint output is silent.
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/d/home/jman/rpms/freecad/python-pycxx/tmp/l3afpad/l3afpad-0.8.18.1.9.tar.xz :
>  MD5SUM this package     : 20fb9527dfd98ce3a607bc43e1e0f4dc
>  MD5SUM upstream package : 20fb9527dfd98ce3a607bc43e1e0f4dc
>
>[X]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[X]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[X]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[X]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[X]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[X]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[X]: SHOULD Package functions as described.
>[X]: SHOULD Latest version is packaged.
>[X]: SHOULD Package does not include license text files separate from
>     upstream.
>[X]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
>     justified.
>[ ]: SHOULD Scriptlets must be sane, if used.
>[x]: SHOULD SourceX is a working URL.
>[X]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>     * Didn't find any on website
>[ ]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: SHOULD %check is present and all tests pass.
>[X]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>Issues:
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>     ** rm -rf %{buildroot} in %install; is this intended for EPEL5?
>[!]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>     ** There is an %{_iconsdir} macro; could replace %{_datadir}/icons
>     ** There is a %{_desktopdir} macro; could replace %{_datadir}/applications
>[!]: MUST Package does not own files or directories owned by other packages.
>     ** Does this pkg need to own all those directories in %{_iconsdir}?
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Patch0: l3afpad-0.8.18.1.9-missing-semicolon.patch
>     (l3afpad-0.8.18.1.9-missing-semicolon.patch)
>     ** I think the script wants you to write:
>     ** Patch0:         %{name}-%{version}-missing-semicolon.patch
>
>
>
>See: None
>
>
>Generated by fedora-review 0.1.3
>External plugins:

Actions: View

Attachments on bug 828993: 595172