Attachment 595219 Details for Bug 772730 – debug.patch

[patch] debug.patch

0001-ACPI-AC-add-check-the-return-value-of-power_supply_r.patch (text/plain), 1.44 KB, created by Lan Tianyu on 2012-06-29 07:24:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lan Tianyu

Created: 2012-06-29 07:24:48 UTC

Size: 1.44 KB

patch

obsolete

>From 43322a70c0807eba956da66505126f99099f71f0 Mon Sep 17 00:00:00 2001
>From: Lan Tianyu <tianyu.lan@intel.com>
>Date: Fri, 29 Jun 2012 14:58:26 +0800
>Subject: [PATCH] ACPI/AC: add check the return value of
> power_supply_regiester()
>
>In the ac.c, lack check return value of power_supply_register().
>This may casue that acpi driver's add() ops was called successful
>while the device may be failed to be initalized. For example, some
>ugly bios may describe two ACADs in the same dsdt. They use the same
>name which will cause the second ACAD device can no be registered.
>And then power_supply_register() failed. But acpi driver's add() ops
>is called sucessfully. The acpi device also will receive acpi notification
>and cause oops.
>	https://bugzilla.redhat.com/show_bug.cgi?id=772730
>---
> drivers/acpi/ac.c |    4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
>diff --git a/drivers/acpi/ac.c b/drivers/acpi/ac.c
>index 6512b20..d1fcbc0 100644
>--- a/drivers/acpi/ac.c
>+++ b/drivers/acpi/ac.c
>@@ -292,7 +292,9 @@ static int acpi_ac_add(struct acpi_device *device)
> 	ac->charger.properties = ac_props;
> 	ac->charger.num_properties = ARRAY_SIZE(ac_props);
> 	ac->charger.get_property = get_ac_property;
>-	power_supply_register(&ac->device->dev, &ac->charger);
>+	result = power_supply_register(&ac->device->dev, &ac->charger);
>+	if (result)
>+		goto end;
> 
> 	printk(KERN_INFO PREFIX "%s [%s] (%s)\n",
> 	       acpi_device_name(device), acpi_device_bid(device),
>-- 
>1.7.6.rc2.8.g28eb
>

Actions: View | Diff

Attachments on bug 772730: 551654 | 551655 | 551656 | 551658 | 551677 | 572207 | 594375 | 595219