Attachment 595412 Details for Bug 575940 – php-pluf-review.txt

php-pluf-review.txt

php-pluf-review.txt (text/plain), 8.79 KB, created by Remi Collet on 2012-06-30 06:38:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-06-30 06:38:12 UTC

Size: 8.79 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>[x]: MUST Sources contain only permissible code or content.
>[!]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[-]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>[-]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>	LGPL v2.1
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[!]: MUST Rpmlint output is silent.
>
>rpmlint php-pluf-1.0-1.fc18.noarch.rpm
>
>php-pluf.noarch: W: spelling-error Summary(fr) Framework -> Frameries
>php-pluf.noarch: W: spelling-error %description -l fr Framework -> Frameries
>php-pluf.noarch: W: spelling-error %description -l fr language -> langage, lagunage, langueyage
>1 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>rpmlint php-pluf-1.0-1.fc18.src.rpm
>
>php-pluf.src: W: spelling-error Summary(fr) Framework -> Frameries
>php-pluf.src: W: spelling-error %description -l fr Framework -> Frameries
>php-pluf.src: W: spelling-error %description -l fr language -> langage, lagunage, langueyage
>php-pluf.src: W: invalid-url Source0: pluf-v1.0.zip
>1 packages and 0 specfiles checked; 0 errors, 4 warnings.
>
>
>[-]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>Package has no sources or they are generated by developer
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
># rpm -q --provides php-pluf
>php-pluf = 1.0-1.fc17.remi
># rpm -q --requires php-pluf
>/bin/sh  
>php-common >= 5.2.4
>php-gd  
>php-mbstring  
>php-mysql  
>php-pear(Mail)  
>php-pear(Mail_Mime)  
>php-pgsql  
>
>[?]: SHOULD Package functions as described.
>[!]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD SourceX is a working URL.
>[x]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[?]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>
>Notes:
>$ phpci print --recursive pluf-v1.0/src/
>REQUIRED PHP 5.2.4 (MIN) 
>
>$ phpci print --recursive --report extension pluf-v1.0/src/
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0            1357
>  PDO                                           1.0.4dev  5.1.0               4
>  Reflection                                              5.0.0               1
>  SPL                                                0.2  5.0.0             134
>  apc                                              3.1.7  4.0.0               2
>  date                                                    4.0.0              67
>  ereg                                                    4.0.0  5.3.0        1
>  gd                                                      4.0.0               9
>  hash                                               1.0  5.1.2               1
>  json                                             1.2.1  5.2.0               8
>  ldap                                                    4.0.0              19
>  mbstring                                                4.0.6              34
>  memcache                                         3.0.6  4.3.3               1
>  mysql                                              1.0  4.0.0              14
>  pcre                                                    4.0.0             219
>  pgsql                                                   4.0.0              13
>  shmop                                                   4.0.0              13
>  standard                                                4.0.0            1906
>  tokenizer                                          0.1  4.2.0              96
>  zlib                                               1.1  4.0.0               9
>-------------------------------------------------------------------------------
>
>Issues:
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
>[!]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>See: None
>[!]: MUST Rpmlint output is silent.
>
>rpmlint php-pluf-1.0-1.fc18.noarch.rpm
>
>php-pluf.noarch: W: spelling-error Summary(fr) Framework -> Frameries
>php-pluf.noarch: W: spelling-error %description -l fr Framework -> Frameries
>php-pluf.noarch: W: spelling-error %description -l fr language -> langage, lagunage, langueyage
>1 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>rpmlint php-pluf-1.0-1.fc18.src.rpm
>
>php-pluf.src: W: spelling-error Summary(fr) Framework -> Frameries
>php-pluf.src: W: spelling-error %description -l fr Framework -> Frameries
>php-pluf.src: W: spelling-error %description -l fr language -> langage, lagunage, langueyage
>php-pluf.src: W: invalid-url Source0: pluf-v1.0.zip
>1 packages and 0 specfiles checked; 0 errors, 4 warnings.
>
>
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
>
>[!]: SHOULD Latest version is packaged.
>=> this still a nightmare... !
>
>
>Generated by fedora-review 0.1.3
>External plugins:

Actions: View

Attachments on bug 575940: 595412