Attachment 595506 Details for Bug 785455 – php-horde-Horde-Support-review.txt

php-horde-Horde-Support-review.txt

php-horde-Horde-Support-review.txt (text/plain), 6.73 KB, created by Remi Collet on 2012-07-01 07:39:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-07-01 07:39:17 UTC

Size: 6.73 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[-]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[x]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>	BSB
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint output is silent.
>
>rpmlint php-horde-Horde-Support-1.0.2-1.fc18.src.rpm
>
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>rpmlint php-horde-Horde-Support-1.0.2-1.fc18.noarch.rpm
>
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/extras/SPECS/review/785455/Horde_Support-1.0.2.tgz :
>  MD5SUM this package     : 2024f60c5e1508531c391b89e28f3251
>  MD5SUM upstream package : 2024f60c5e1508531c391b89e28f3251
>
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
># rpm -q --provides php-horde-Horde-Support
>php-pear(pear.horde.org/Horde_Support) = 1.0.2
>php-horde-Horde-Support = 1.0.2-1.fc17.remi
># rpm -q --requires php-horde-Horde-Support
>/bin/sh  
>/usr/bin/pear  
>php-channel(pear.horde.org)  
>php-pear(PEAR) >= 1.7.0
>php-pear(pear.horde.org/Horde_Exception) < 2.0.0
>php-pear(pear.horde.org/Horde_Stream_Wrapper) < 2.0.0
>[?]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>	(un)install the packeh properly (un)register the extension
>[x]: SHOULD SourceX is a working URL.
>[x]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>Notes:
>REQUIRED PHP 5.2.0 (MIN) 
>
>$ phpci print --recursive --report class Horde_Support-1.0.2/lib/ | grep -v Horde_Support
>-------------------------------------------------------------------------------
>  CLASS                                 EXTENSION         VERSION         COUNT
>-------------------------------------------------------------------------------
>  Exception                             SPL               5.1.0               9
>  InvalidArgumentException              SPL               5.1.0               2
>  SplFileObject                         SPL               5.1.0               2
>  Horde_Exception                                         4.0.0               1
>-------------------------------------------------------------------------------
>$ phpci print --recursive --report extension Horde_Support-1.0.2/lib/ 
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              49
>  SPL                                                0.2  5.0.0              23
>  date                                                    4.0.0               1
>  pcre                                                    4.0.0              22
>  standard                                                4.0.0             125
>-------------------------------------------------------------------------------
>
>
>
>Issues:
>Should use same PEAR version for BuildRequires and Requires
>Requires php-common >= 5.2.0 (could also add php-date, php-pcre and php-spl)
>Use %{pear_name} where possible (%file)
>Consider adding %{pear_channel) for "pear.horde.org"
>
>Generated by fedora-review 0.1.3
>External plugins:

Flags:

fedora: review?

Actions: View

Attachments on bug 785455: 595506