Attachment 595771 Details for Bug 837032 – x86: emulate lea with two register operands correctly

[patch] x86: emulate lea with two register operands correctly

0001-x86-emulate-lea-with-two-register-operands-correctly.patch (text/plain), 1.21 KB, created by Igor Mammedov on 2012-07-02 16:47:23 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Igor Mammedov

Created: 2012-07-02 16:47:23 UTC

Size: 1.21 KB

patch

obsolete

>From 78454d77340c3b168f8cca12ccb07d7913fc39fd Mon Sep 17 00:00:00 2001
>From: Igor Mammedov <imammedo@redhat.com>
>Date: Fri, 29 Jun 2012 14:50:02 +0200
>Subject: [RHEL5.9 Xen 1/2] x86: emulate lea with two register operands
> correctly
>
>Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=837032
>Upstream xen-unstable c/s: 24456
>Brew: http://brewweb.devel.redhat.com/brew/taskinfo?taskID=4567083
>
>-----------
>An lea instruction with two register operands should raise an
>undefined instruction exception.
>
>Skype does such a instruction and will crash when starting if it does
>not get the exception.
>
>Signed-off-by: David Vrabel <david.vrabel@citrix.com>
>Signed-off-by: Keir Fraser <keir@xen.org>
>Committed-by: Keir Fraser <keir@xen.org>
>------------
>Signed-off-by: Igor Mammedov <imammedo@redhat.com>
>---
> arch/x86/x86_emulate.c |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
>diff --git a/arch/x86/x86_emulate.c b/arch/x86/x86_emulate.c
>index 69acba0..c03c4f6 100644
>--- a/arch/x86/x86_emulate.c
>+++ b/arch/x86/x86_emulate.c
>@@ -1289,6 +1289,7 @@ x86_emulate(
>         break;
> 
>     case 0x8d: /* lea */
>+        generate_exception_if(ea.type != OP_MEM, EXC_UD);
>         dst.val = ea.mem.off;
>         break;
> 
>-- 
>1.7.5
>

Actions: View | Diff

Attachments on bug 837032: 595771 | 595772