Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 595977 Details for
Bug 837319
CVE-2012-3374 pidgin: Stack-based buffer overwrite in MXit protocol libPurple plug-in
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Local copy of proposed Pidgin upstream patch for MXit protocol plug-in
fix_mxit_inline_image_buffer_overflow_v1.diff (text/plain), 866 bytes, created by
Jan Lieskovsky
on 2012-07-03 13:12:24 UTC
(
hide
)
Description:
Local copy of proposed Pidgin upstream patch for MXit protocol plug-in
Filename:
MIME Type:
Creator:
Jan Lieskovsky
Created:
2012-07-03 13:12:24 UTC
Size:
866 bytes
patch
obsolete
>diff -r a5a5365dbaa5 libpurple/protocols/mxit/markup.c >--- a/libpurple/protocols/mxit/markup.c Thu Jun 14 21:48:21 2012 +0100 >+++ b/libpurple/protocols/mxit/markup.c Sat Jun 30 19:51:10 2012 -0700 >@@ -361,7 +361,7 @@ > int start; > unsigned int end; > int emo_ofs; >- char ii[128]; >+ char* ii; > char tag[64]; > int* img_id; > >@@ -379,8 +379,7 @@ > if ( end == mx->msg->len ) /* end of emoticon tag not found */ > break; > >- memset( ii, 0x00, sizeof( ii ) ); >- memcpy( ii, &mx->msg->str[emo_ofs], end - emo_ofs ); >+ ii = g_strndup(&mx->msg->str[emo_ofs], end - emo_ofs); > > /* remove inline image tag */ > g_string_erase( mx->msg, start, ( end - start ) + 1 ); >@@ -396,6 +395,8 @@ > g_snprintf( tag, sizeof( tag ), "<img id=\"%i\">", *img_id ); > g_string_insert( mx->msg, start, tag ); > } >+ >+ g_free(ii); > } > } >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=595977">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 837319
: 595977