Attachment 596283 Details for Bug 836587 – Package review (initially generated by fedora-review 0.1.3)

Package review (initially generated by fedora-review 0.1.3)

php-htmLawed-review.txt (text/plain), 9.43 KB, created by Shawn Iwinski on 2012-07-04 20:01:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2012-07-04 20:01:29 UTC

Size: 9.43 KB

patch

obsolete

>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>
>--- Scratch builds ---
>rawhide: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218689 (completed successfully)
>Fedora 17: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218694 (completed successfully)
>Fedora 16: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218692 (completed successfully)
>EPEL 6: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218700 (completed successfully)
>EPEL 5: http://koji.fedoraproject.org/koji/taskinfo?taskID=4218696 (failed; temp issue; works for packager)
>
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package requires other packages for directories it uses.
>
>$ phpci print --report=extension .
>2 / 2 [+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++>] 100.00%
>BASE: /home/siwinski/projects/fedora/reviews/836587/src
>-------------------------------------------------------------------------------
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              37
>  ctype                                                   4.0.4               4
>  pcre                                                    4.0.0              56
>  session                                                 4.0.0               8
>  standard                                                4.0.0             336
>-------------------------------------------------------------------------------
>A TOTAL OF 5 EXTENSION(S) WERE FOUND
>WITH CONDITIONAL CODE LEVEL 5
>REQUIRED PHP 4.0.4 (MIN) 
>-------------------------------------------------------------------------------
>Time: 2 seconds, Memory: 33.75Mb
>-------------------------------------------------------------------------------
>
>$ phpci print --report=class .
>2 / 2 [+++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++>] 100.00%
>BASE: /home/siwinski/projects/fedora/reviews/836587/src
>
>-------------------------------------------------------------------------------
>PHP COMPAT INFO CLASS SUMMARY
>-------------------------------------------------------------------------------
>  CLASS                                 EXTENSION         VERSION         COUNT
>-------------------------------------------------------------------------------
>-------------------------------------------------------------------------------
>A TOTAL OF 0 CLASS(S) WERE FOUND
>WITH CONDITIONAL CODE LEVEL 5
>-------------------------------------------------------------------------------
>Time: 0 seconds, Memory: 8.75Mb
>-------------------------------------------------------------------------------
>
>[x]: MUST Package uses nothing in %doc for runtime.
>[x]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>[x]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint output is silent.
>
>rpmlint php-htmLawed-1.1.11-2.fc18.src.rpm
>
>php-htmLawed.src: W: spelling-error %description -l en_US customizable -> customization
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>
>rpmlint php-htmLawed-1.1.11-2.fc18.noarch.rpm
>
>php-htmLawed.noarch: W: spelling-error %description -l en_US customizable -> customization
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>Acceptable
>
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/siwinski/projects/fedora/reviews/836587/htmLawed.zip :
>  MD5SUM this package     : 11417fedeaf5303326ff6dfa8d6ee6b9
>  MD5SUM upstream package : 11417fedeaf5303326ff6dfa8d6ee6b9
>
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[-]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[x]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>
>http://www.bioinformatics.org/phplabware/forum/viewtopic.php?id=220
>
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>
>$ rpm -qp --provides php-htmLawed-1.1.11-2.fc17.noarch.rpm
>php-htmLawed = 1.1.11-1.fc17
>
>$ rpm -qp --requires php-htmLawed-1.1.11-2.fc17.noarch.rpm
>php-ctype  
>php-pcre  
>rpmlib(CompressedFileNames) <= 3.0.4-1
>rpmlib(FileDigests) <= 4.6.0-1
>rpmlib(PayloadFilesHavePrefix) <= 4.0-1
>rpmlib(PayloadIsXz) <= 5.2-1
>
>[x]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>
>
>Issues:
>[x]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#FilePermissions
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>See: None
>
>Acceptable. Package target is Fedora >= 16 and EPEL >= 5.
>
>[x]: MUST Rpmlint output is silent.
>
>rpmlint php-htmLawed-1.1.11-2.fc18.src.rpm
>
>php-htmLawed.src: W: spelling-error %description -l en_US customizable -> customization
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>
>rpmlint php-htmLawed-1.1.11-2.fc18.noarch.rpm
>
>php-htmLawed.noarch: W: spelling-error %description -l en_US customizable -> customization
>1 packages and 0 specfiles checked; 0 errors, 1 warnings.
>
>
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
>
>Acceptable
>
>
>Generated by fedora-review 0.1.3
>External plugins:
>

Actions: View

Attachments on bug 836587: 596283