Attachment 596674 Details for Bug 838004 – iwlwifi-do-not-send-lq-cmd-when-station-add-fails.patch

[patch] iwlwifi-do-not-send-lq-cmd-when-station-add-fails.patch

iwlwifi-do-not-send-lq-cmd-when-station-add-fails.patch (text/plain), 2.19 KB, created by John W. Linville on 2012-07-06 17:43:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: John W. Linville

Created: 2012-07-06 17:43:46 UTC

Size: 2.19 KB

patch

obsolete

>From f4c37176ef555560a1d13bc4bf2cf3debd442f40 Mon Sep 17 00:00:00 2001
>From: Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>
>Date: Wed, 16 May 2012 22:49:48 +0200
>Subject: [PATCH] iwlwifi: do not send lq cmd when station add fails
>
>When adding a station fails in
>iwl_restore_stations, the driver treats it
>like a successful station add and sends a
>link quality command, when it it shouldn't.
>
>This patch fixes one of the potential
>sources for kernel warnings like this one:
>
>WARNING: at drivers/net/wireless/iwlwifi/iwl-agn-sta.c:905 iwl_send_lq_cmd+0x130/0x217 [iwlwifi]()
>Hardware name: 3323A2G
>Modules linked in: ...
>Pid: 17359, comm: kworker/u:2 Tainted: G           O 3.3.0-wl+ #1
>Call Trace:
> [<ffffffff81039620>] warn_slowpath_common+0x7e/0x96
> [<ffffffff8103964d>] warn_slowpath_null+0x15/0x17
> [<ffffffffa02a9f0b>] iwl_send_lq_cmd+0x130/0x217 [iwlwifi]
> [<ffffffffa02aa1fb>] iwl_restore_stations+0x209/0x289 [iwlwifi]
> [<ffffffffa02b07c2>] iwlagn_commit_rxon+0x602/0x7bd [iwlwifi]
> [<ffffffffa02b111f>] iwlagn_bss_info_changed+0x247/0x31a [iwlwifi]
> [<ffffffffa0861437>] ieee80211_bss_info_change_notify+0x1a5/0x1ba [mac80211]
> [<ffffffffa088afad>] ieee80211_destroy_auth_data+0x4b/0x70 [mac80211]
> [<ffffffffa088df26>] ieee80211_sta_work+0xb5/0x954 [mac80211]
>
>Signed-off-by: Meenakshi Venkataraman <meenakshi.venkataraman@intel.com>
>Reviewed-by: Wey-Yi W Guy <wey-yi.w.guy@intel.com>
>Reviewed-by: Emmanuel Grumbach <emmanuel.grumbach@intel.com>
>Signed-off-by: Johannes Berg <johannes.berg@intel.com>
>Signed-off-by: John W. Linville <linville@tuxdriver.com>
>---
> drivers/net/wireless/iwlwifi/iwl-agn-sta.c |    2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
>index b31584e..aea07aa 100644
>--- a/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
>+++ b/drivers/net/wireless/iwlwifi/iwl-agn-sta.c
>@@ -772,7 +772,7 @@ void iwl_restore_stations(struct iwl_priv *priv, struct iwl_rxon_context *ctx)
> 						~IWL_STA_DRIVER_ACTIVE;
> 				priv->stations[i].used &=
> 						~IWL_STA_UCODE_INPROGRESS;
>-				spin_unlock_bh(&priv->sta_lock);
>+				continue;
> 			}
> 			/*
> 			 * Rate scaling has already been initialized, send
>-- 
>1.7.10.2
>

Actions: View | Diff

Attachments on bug 838004: 596674