Attachment 597985 Details for Bug 821404 – fedora-review log

fedora-review log

gimp-dds-plugin-review.txt (text/plain), 8.65 KB, created by Vasiliy Glazov on 2012-07-13 06:25:17 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Vasiliy Glazov

Created: 2012-07-13 06:25:17 UTC

Size: 8.65 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== C/C++ ====
>[x]: MUST Header files in -devel subpackage, if present.
>[x]: MUST Package does not contain any libtool archives (.la)
>[ ]: MUST Package does not contain kernel modules.
>[ ]: MUST Package contains no static executables.
>[ ]: MUST Rpath absent or only used for internal libs.
>[ ]: MUST Package is not relocatable.
>
>
>==== Generic ====
>[ ]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[ ]: MUST Package contains no bundled libraries.
>[ ]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[ ]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
>[ ]: MUST Package requires other packages for directories it uses.
>[ ]: MUST Package uses nothing in %doc for runtime.
>[ ]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[ ]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[ ]: MUST License field in the package spec file matches the actual license.
>[ ]: MUST Package consistently uses macros (instead of hard-coded directory
>     names).
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[ ]: MUST Package does not generate any conflict.
>[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[ ]: MUST Package must own all directories that it creates.
>[ ]: MUST Package does not own files or directories owned by other packages.
>[ ]: MUST Package installs properly.
>[ ]: MUST Requires correct, justified where necessary.
>[!]: MUST Rpmlint output is silent.
>
>rpmlint gimp-dds-plugin-2.1.0-1.fc18.i686.rpm
>
>gimp-dds-plugin.i686: W: spelling-error Summary(ru) ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>gimp-dds-plugin.i686: W: spelling-error %description -l ru ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>rpmlint gimp-dds-plugin-debuginfo-2.1.0-1.fc18.i686.rpm
>
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/mipmap.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/mipmap.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddswrite.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/misc.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddsread.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dxt.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dxt.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/color.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/color.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dds.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dds.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/misc.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/imath.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddsplugin.h
>1 packages and 0 specfiles checked; 14 errors, 0 warnings.
>
>
>rpmlint gimp-dds-plugin-2.1.0-1.fc18.src.rpm
>
>gimp-dds-plugin.src: W: spelling-error Summary(ru) ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>gimp-dds-plugin.src: W: spelling-error %description -l ru ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>/home/vascom/Dropbox/github/gimp-dds-plugin/gimp-dds-2.1.0.tar.bz2 :
>  MD5SUM this package     : ca4457d70186c54c7a46f3058203d62b
>  MD5SUM upstream package : ca4457d70186c54c7a46f3058203d62b
>
>[ ]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: MUST Package contains a SysV-style init script if in need of one.
>[x]: MUST File names are valid UTF-8.
>[ ]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[ ]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[ ]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: SHOULD Package functions as described.
>[ ]: SHOULD Latest version is packaged.
>[ ]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD SourceX is a working URL.
>[ ]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: SHOULD %check is present and all tests pass.
>[ ]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>Issues:
>[!]: MUST Rpmlint output is silent.
>
>rpmlint gimp-dds-plugin-2.1.0-1.fc18.i686.rpm
>
>gimp-dds-plugin.i686: W: spelling-error Summary(ru) ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>gimp-dds-plugin.i686: W: spelling-error %description -l ru ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>rpmlint gimp-dds-plugin-debuginfo-2.1.0-1.fc18.i686.rpm
>
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/mipmap.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/mipmap.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddswrite.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/misc.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddsread.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dxt.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dxt.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/color.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/color.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dds.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/dds.c
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/misc.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/imath.h
>gimp-dds-plugin-debuginfo.i686: E: incorrect-fsf-address /usr/src/debug/gimp-dds-2.1.0/ddsplugin.h
>1 packages and 0 specfiles checked; 14 errors, 0 warnings.
>
>
>rpmlint gimp-dds-plugin-2.1.0-1.fc18.src.rpm
>
>gimp-dds-plugin.src: W: spelling-error Summary(ru) ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>gimp-dds-plugin.src: W: spelling-error %description -l ru ÐÐ»Ð°Ð³Ð¸Ð½ -> ÐÐ»Ð°Ð³Ð¸Ð°Ñ
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
>
>
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#rpmlint
>
>
>Generated by fedora-review 0.1.3
>External plugins:

Actions: View

Attachments on bug 821404: 597985