Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 598767 Details for
Bug 840822
Crash in __pmDecodeCreds decoding crafted PDUs
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
preliminary patch to __pmDecodeCreds to fix this
pcp_creds.patch (text/plain), 854 bytes, created by
Mark Goodwin
on 2012-07-18 00:30:25 UTC
(
hide
)
Description:
preliminary patch to __pmDecodeCreds to fix this
Filename:
MIME Type:
Creator:
Mark Goodwin
Created:
2012-07-18 00:30:25 UTC
Size:
854 bytes
patch
obsolete
>diff --git a/src/libpcp/src/p_creds.c b/src/libpcp/src/p_creds.c >index 597edb9..6a423a3 100644 >--- a/src/libpcp/src/p_creds.c >+++ b/src/libpcp/src/p_creds.c >@@ -61,12 +61,18 @@ __pmDecodeCreds(__pmPDU *pdubuf, int *sender, int *credcount, __pmCred **credlis > { > creds_t *pp; > int i; >+ int len; >+ int need; > int numcred; > __pmCred *list; > > pp = (creds_t *)pdubuf; >+ len = pp->hdr.len; /* ntohl() converted already in __pmGetPDU() */ > numcred = ntohl(pp->numcreds); >- if (pp == NULL || numcred < 0) return PM_ERR_IPC; >+ need = sizeof(creds_t) + ((numcred-1) * sizeof(__pmCred)); >+ if (numcred < 0 || need != len) >+ return PM_ERR_IPC; >+ > *sender = pp->hdr.from; /* ntohl() converted already in __pmGetPDU() */ > if ((list = (__pmCred *)malloc(sizeof(__pmCred) * numcred)) == NULL) > return -oserror();
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=598767">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 840822
: 598767 |
599108