Attachment 600192 Details for Bug 790869 – Whitelist for valid explicit "lib" packages

[patch] Whitelist for valid explicit "lib" packages

rpmlint-1.4-rhbz790869.patch (text/plain), 1.09 KB, created by Andy Grimm on 2012-07-25 01:29:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andy Grimm

Created: 2012-07-25 01:29:00 UTC

Size: 1.09 KB

patch

obsolete

>diff -urN rpmlint-1.4/TagsCheck.py rpmlint-1.4.new/TagsCheck.py
>--- rpmlint-1.4/TagsCheck.py	2011-11-27 15:35:51.000000000 -0500
>+++ rpmlint-1.4.new/TagsCheck.py	2012-07-24 21:07:43.055591205 -0400
>@@ -400,6 +400,8 @@
> 
> DEFAULT_INVALID_REQUIRES = ('^is$', '^not$', '^owned$', '^by$', '^any$', '^package$', '^libsafe\.so\.')
> 
>+VALID_EXPLICIT_LIBS = ('msv-xsdlib', 'python-httplib2')
>+
> VALID_GROUPS = Config.getOption('ValidGroups', None)
> if VALID_GROUPS is None: # get defaults from rpm package only if it's not set
>     VALID_GROUPS = Pkg.get_default_valid_rpmgroups()
>@@ -611,7 +613,7 @@
>                 printError(pkg, 'invalid-build-requires', d[0])
>             if not is_source and not is_devel:
>                 res = lib_package_regex.search(d[0])
>-                if res and not res.group(1) and not d[1]:
>+                if res and not res.group(1) and not d[1] and d[0] not in VALID_EXPLICIT_LIBS:
>                     printError(pkg, 'explicit-lib-dependency', d[0])
>             if d[1] == rpm.RPMSENSE_EQUAL and d[2][2] is not None:
>                 printWarning(pkg, 'requires-on-release', value)

Actions: View | Diff

Attachments on bug 790869: 600192