Attachment 600315 Details for Bug 843083 – Backported fix from RHEL6

[patch] Backported fix from RHEL6

0001-fence_xvm-Fix-incorrect-success-return-codes.patch (text/plain), 1.24 KB, created by Ryan McCabe on 2012-07-25 14:48:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ryan McCabe

Created: 2012-07-25 14:48:51 UTC

Size: 1.24 KB

patch

obsolete

>From 2e152895c7b69047bcbd33980e9bdb21ef5d2bb6 Mon Sep 17 00:00:00 2001
>From: Ryan McCabe <rmccabe@redhat.com>
>Date: Wed, 25 Jul 2012 10:40:19 -0400
>Subject: [PATCH] fence_xvm: Fix incorrect success return codes
>
>This patch fixes two places where fence_xvm will return success
>for fencing operations when fencing has failed due to the
>challenge/response failing.
>
>Resolves: rhbz#843083
>
>Signed-off-by: Ryan McCabe <rmccabe@redhat.com>
>---
> fence/agents/xvm/fence_xvm.c |    4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/fence/agents/xvm/fence_xvm.c b/fence/agents/xvm/fence_xvm.c
>index d1ffb12..eb006fd 100644
>--- a/fence/agents/xvm/fence_xvm.c
>+++ b/fence/agents/xvm/fence_xvm.c
>@@ -99,14 +99,14 @@ tcp_exchange(int fd, fence_auth_type_t auth, void *key,
> 	if (tcp_challenge(fd, auth, key, key_len, timeout) <= 0) {
> 		/* Challenge failed */
> 		printf("Invalid response to challenge\n");
>-		return 0;
>+		return 1;
> 	}
> 
> 	/* Now they'll send us one, so we need to respond here */
> 	dbg_printf(3, "Responding to TCP challenge\n");
> 	if (tcp_response(fd, auth, key, key_len, timeout) <= 0) {
> 		printf("Invalid response to challenge\n");
>-		return 0;
>+		return 1;
> 	}
> 
> 	dbg_printf(2, "TCP Exchange + Authentication done... \n");
>-- 
>1.7.10.4
>

Actions: View | Diff

Attachments on bug 843083: 600315