Attachment 600376 Details for Bug 827474 – perf-evsel-Fix-an-issue-where-perf-report-fails-to-s.patch

perf-evsel-Fix-an-issue-where-perf-report-fails-to-s.patch

0001-perf-evsel-Fix-an-issue-where-perf-report-fails-to-s.patch (text/plain), 2.42 KB, created by IBM Bug Proxy on 2012-07-25 18:54:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2012-07-25 18:54:19 UTC

Size: 2.42 KB

patch

obsolete

>From 838d7aabe2a5c93aa7116f1a74758731ba1a0264 Mon Sep 17 00:00:00 2001
>From: "Naveen N. Rao" <naveen.n.rao@linux.vnet.ibm.com>
>Date: Fri, 3 Feb 2012 22:31:13 +0530
>Subject: [PATCH] perf evsel: Fix an issue where perf report fails to show the
> proper percentage
>
>commit a4a03fc7ef89020baca4f19174e6a43767c6d78a upstream.
>
>This patch fixes an issue where perf report shows nan% for certain
>perf.data files. The below is from a report for a do_fork probe:
>
>   -nan%           sshd  [kernel.kallsyms]  [k] do_fork
>   -nan%    packagekitd  [kernel.kallsyms]  [k] do_fork
>   -nan%    dbus-daemon  [kernel.kallsyms]  [k] do_fork
>   -nan%           bash  [kernel.kallsyms]  [k] do_fork
>
>A git bisect shows commit f3bda2c as the cause. However, looking back
>through the git history, I saw commit 640c03c which seems to have
>removed the required initialization for perf_sample->period. The problem
>only started showing after commit f3bda2c. The below patch re-introduces
>the initialization and it fixes the problem for me.
>
>With the below patch, for the same perf.data:
>
>  73.08%             bash  [kernel.kallsyms]  [k] do_fork
>   8.97%      11-dhclient  [kernel.kallsyms]  [k] do_fork
>   6.41%             sshd  [kernel.kallsyms]  [k] do_fork
>   3.85%        20-chrony  [kernel.kallsyms]  [k] do_fork
>   2.56%         sendmail  [kernel.kallsyms]  [k] do_fork
>
>This patch applies over current linux-tip commit 9949284.
>
>Problem introduced in:
>
>$ git describe 640c03c
>v2.6.37-rc3-83-g640c03c
>
>Cc: Ananth N Mavinakayanahalli <ananth@in.ibm.com>
>Cc: Ingo Molnar <mingo@elte.hu>
>Cc: Robert Richter <robert.richter@amd.com>
>Cc: Srikar Dronamraju <srikar@linux.vnet.ibm.com>
>Link: http://lkml.kernel.org/r/20120203170113.5190.25558.stgit@localhost6.localdomain6
>Signed-off-by: Naveen N. Rao <naveen.n.rao@linux.vnet.ibm.com>
>Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
>---
> tools/perf/util/evsel.c |    1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/tools/perf/util/evsel.c b/tools/perf/util/evsel.c
>index d7915d4..efca198 100644
>--- a/tools/perf/util/evsel.c
>+++ b/tools/perf/util/evsel.c
>@@ -390,6 +390,7 @@ int perf_event__parse_sample(const union perf_event *event, u64 type,
> 	memset(data, 0, sizeof(*data));
> 	data->cpu = data->pid = data->tid = -1;
> 	data->stream_id = data->id = data->time = -1ULL;
>+	data->period = 1;
> 
> 	if (event->header.type != PERF_RECORD_SAMPLE) {
> 		if (!sample_id_all)
>-- 
>1.7.9.5
>

Actions: View

Attachments on bug 827474: 600376 | 600377