Attachment 600451 Details for Bug 784145 – Additional patch to fix the build with -Werror on Fedora 17

Additional patch to fix the build with -Werror on Fedora 17

file_784145.txt (text/plain), 1.54 KB, created by Niels de Vos on 2012-07-26 07:45:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Niels de Vos

Created: 2012-07-26 07:45:54 UTC

Size: 1.54 KB

patch

obsolete

>--- libomxil-bellagio-0.9.3/src/omxregister.c.orig	2012-07-26 09:23:47.878999675 +0200
>+++ libomxil-bellagio-0.9.3/src/omxregister.c	2012-07-26 09:40:02.823999848 +0200
>@@ -216,6 +216,7 @@
> 			continue;
> 		}
> 		while((dp = readdir(dirp)) != NULL) {
>+			int err;
> 			int len = strlen(dp->d_name);
> 
> 			if(len >= 3){
>@@ -246,9 +247,15 @@
> 							stComponents[i]->multiResourceLevel = NULL;
> 						}
> 						fptr(stComponents);
>-						fwrite(lib_absolute_path, 1, strlen(lib_absolute_path), omxregistryfp);
>-						fwrite("\n", 1, 1, omxregistryfp);
>-
>+						err = fwrite(lib_absolute_path, 1, strlen(lib_absolute_path), omxregistryfp);
>+						if (err != strlen(lib_absolute_path)) {
>+							DEBUG(DEB_LEV_ERR, "Failed to write %ld bytes to fd %d\n", strlen(lib_absolute_path), fileno(omxregistryfp));
>+							continue;
>+						}
>+						if (fwrite("\n", 1, 1, omxregistryfp) != 1) {
>+							DEBUG(DEB_LEV_ERR, "Failed to write 1 byte to fd %d\n", fileno(omxregistryfp));
>+							continue;
>+						}
> 
> 						for (i = 0; i<num_of_comp; i++) {
> 							tempName = allNames;
>@@ -322,7 +329,11 @@
> 							}
> 							qualityString[0] = '\0';
> 							strcat(buffer, "\n");
>-							fwrite(buffer, 1, strlen(buffer), omxregistryfp);
>+							err = fwrite(buffer, 1, strlen(buffer), omxregistryfp);
>+							if (err != strlen(buffer)) {
>+								DEBUG(DEB_LEV_ERR, "Failed to write %ld bytes to fd %d\n", strlen(buffer), fileno(omxregistryfp));
>+								continue;
>+							}
> 							ncomponents++;
> 						}
> 						for (i = 0; i < num_of_comp; i++) {

Actions: View

Attachments on bug 784145: 579325 | 600451