Attachment 601019 Details for Bug 698991 – Propsal: do not use libparanoia II, update icedax man page

[patch] Propsal: do not use libparanoia II, update icedax man page

patch-cdrkit-698991 (text/plain), 4.88 KB, created by Manfred Spraul on 2012-07-29 11:56:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Manfred Spraul

Created: 2012-07-29 11:56:53 UTC

Size: 4.88 KB

patch

obsolete

>diff -urN o/SOURCES/cdrkit-1.1.11-noparanoia.patch n/SOURCES/cdrkit-1.1.11-noparanoia.patch
>--- o/SOURCES/cdrkit-1.1.11-noparanoia.patch	1970-01-01 01:00:00.000000000 +0100
>+++ n/SOURCES/cdrkit-1.1.11-noparanoia.patch	2012-07-29 13:53:09.599905779 +0200
>@@ -0,0 +1,83 @@
>+--- cdrkit-orig/icedax/icedax.1	2012-07-28 16:18:33.069059725 +0200
>++++ cdrkit-1.1.11/icedax/icedax.1	2012-07-28 16:30:25.503585651 +0200
>+@@ -82,7 +82,6 @@ files
>+ .IR count ]
>+ .RB [ -S
>+ .IR speed ]
>+-.RB [ -paranoia ]
>+ .RB [ cddbp-server=servername ]
>+ .RB [ cddbp-port=portnumber ]
>+ .RI [ filename(s)
>+@@ -351,9 +350,6 @@ specification on the current operating s
>+ .B wodim(1)
>+ for details.
>+ .TP
>+-.B \-paranoia
>+-use the paranoia library instead of icedax's routines for reading.
>+-.TP
>+ .B \-h " --help"
>+ display version of icedax on standard output.
>+ .TP
>+@@ -739,21 +735,7 @@ a value of 1 often selects single speed.
>+ .B \-M " count"
>+ enables calculation of MD-5 checksum for 'count' bytes from the beginning of a
>+ track. This was introduced for quick comparisons of tracks.
>+-.IP "Use Monty's libparanoia for reading of sectors"
>+-.B \-paranoia
>+-selects an alternate way of extracting audio sectors. Monty's library is used
>+-with the following default options:
>+-.sp
>+-PARANOIA_MODE_FULL, but without PARANOIA_MODE_NEVERSKIP
>+-.sp
>+-for details see Monty's libparanoia documentation.
>+-In this case the option
>+-.B \-P
>+-has no effect.
>+ .IP "Do linear or overlapping reading of sectors"
>+-(This applies unless option
>+-.B \-paranoia
>+-is used.)
>+ .B \-P " sectors"
>+ sets the given number of sectors for initial overlap sampling for jitter
>+ correction. Two cases are to be distinguished. For nonzero values,
>+@@ -977,6 +959,10 @@ is not optimal.
>+ Icedax should use threads.
>+ .sp
>+ Icedax currently cannot sample hidden audio tracks (track 1 index 0).
>++.sp
>++No -paranoia:
>++The option uses libparanoia II which is not capable of bypassing the cache on
>++modern drives and icedax does not support libparanoia III.
>+ .SH ACKNOWLEDGEMENTS
>+ Thanks goto Project MODE (http://www.mode.net/) and Fraunhofer Institut f\*ur
>+ integrierte Schaltungen (FhG-IIS) (http://www.iis.fhg.de/) for financial
>+@@ -985,7 +971,6 @@ Plextor Europe and Ricoh Japan provided
>+ which helped a lot to develop this software.
>+ Rammi has helped a lot with the debugging and showed a lot of stamina when
>+ hearing 100 times the first 16 seconds of the first track of the Krupps CD.
>+-Libparanoia contributed by Monty (Christopher Montgomery) xiphmont@mit.edu.
>+ .SH AUTHOR
>+ Heiko Eissfeldt heiko@colossus.escape.de
>+ .PP
>+--- cdrkit-orig/icedax/local.cnf.in	2012-07-28 16:18:33.068059769 +0200
>++++ cdrkit-1.1.11/icedax/local.cnf.in	2012-07-29 13:38:47.287379064 +0200
>+@@ -129,7 +129,7 @@
>+ CDDA2WAVDEFS=-DCD_DEVICE=$(DEF_DEVICE) -DFILENAME=$(DEF_FILE) \
>+ -DUNDERSAMPLING=$(DEF_UNDERSAMPLING) -DVERSION=$(CUR_VERSION) \
>+ -DBITS_P_S=$(DEF_BITS) -DCHANNELS=$(DEF_CHANNELS) -DAUDIOTYPE=$(DEF_TYPE) \
>+--DDURATION=$(DEF_TIME) -DDEF_INTERFACE=$(INTERFACE) -DUSE_PARANOIA=1 \
>++-DDURATION=$(DEF_TIME) -DDEF_INTERFACE=$(INTERFACE) \
>+ -DDEFAULT_SPEED=$(DEF_SPEED) $(WANT_CDINDEX_SUPPORT) $(WANT_CDDB_SUPPORT) \
>+ -DCDDBHOST=$(CDDB_SERVERHOST) -DCDDBPORT=$(CDDB_SERVERPORT) $(HAVE_IOCTL) \
>+ $(HAVE_SOUND) -DSOUND_DEV=$(SOUND_DEVICE) -DNSECTORS=$(NSECTORS) \
>+--- cdrkit-orig/icedax/lconfig.h	2012-07-28 16:18:33.073059553 +0200
>++++ cdrkit-1.1.11/icedax/lconfig.h	2012-07-29 13:50:22.239984055 +0200
>+@@ -69,7 +69,7 @@
>+ #define AUDIOTYPE "wav"
>+ #define DURATION 0
>+ #define DEF_INTERFACE "generic_scsi"
>+-#define USE_PARANOIA 1
>++/* #define USE_PARANOIA 1 */
>+ #define DEFAULT_SPEED 0
>+ #define CDINDEX_SUPPORT
>+ #define CDDB_SUPPORT
>diff -urN o/SPECS/cdrkit.spec n/SPECS/cdrkit.spec
>--- o/SPECS/cdrkit.spec	2012-07-29 13:19:14.529987914 +0200
>+++ n/SPECS/cdrkit.spec	2012-07-29 13:17:39.086012232 +0200
>@@ -1,7 +1,7 @@
> Summary: A collection of CD/DVD utilities
> Name: cdrkit
> Version: 1.1.11
>-Release: 11%{?dist}
>+Release: 12%{?dist}
> License: GPLv2
> Group: Applications/System
> URL: http://cdrkit.org/
>@@ -20,6 +20,7 @@
> Patch11: cdrkit-1.1.11-format.patch
> Patch12: cdrkit-1.1.11-handler.patch
> Patch13: cdrkit-1.1.11-dvdman.patch
>+Patch14: cdrkit-1.1.11-noparanoia.patch
> 
> BuildRequires: cmake libcap-devel zlib-devel perl file-devel bzip2-devel
> 
>@@ -114,6 +115,7 @@
> %patch11 -p1 -b .format
> %patch12 -p1 -b .handler
> %patch13 -p1 -b .dvdman
>+%patch14 -p1 -b .noparanoia
> 
> find . -type f -print0 | xargs -0 perl -pi -e 's#/usr/local/bin/perl#/usr/bin/perl#g'
> find doc -type f -print0 | xargs -0 chmod a-x 
>@@ -269,6 +271,10 @@
> %{_includedir}/usal
> 
> %changelog
>+* Sun Jul 28 2012 Manfred Spraul <manfred@colorfullife.com> - 1.1.11-12
>+- "-paranoia" option disabled, it relies on libparanoia II which does not work on
>+  modern drives (Resolves: #698991).
>+
> * Wed Jul 18 2012 Fedora Release Engineering <rel-eng@lists.fedoraproject.org> - 1.1.11-11
> - Rebuilt for https://fedoraproject.org/wiki/Fedora_18_Mass_Rebuild
>

Actions: View | Diff

Attachments on bug 698991: 601019 | 601296