Attachment 601353 Details for Bug 844500 – The file showing where I think changes should be made

The file showing where I think changes should be made

kinit.cpp (text/plain), 1.55 KB, created by bugz on 2012-07-30 23:03:08 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: bugz

Created: 2012-07-30 23:03:08 UTC

Size: 1.55 KB

patch

obsolete

>// The following code, from kdelibs-4.3.4/kinit/kinit.cpp line 506, is mistaken.
>// It has the ruinous side efect that shells in terminal programs such as
>//  koneole, xterm and so on are started in users' Documents whereas login terminals
>//  and comminucation programs such as ssh start them in userÂ´s home directories.
>//  Personally, I can think of a good reason to start any program in a user's 
>//  Documents directory, but where that is a programÂ´s expecation, then it should
>//  be a configuration item.
>//
>//  ProgramsÂ´  behaviour should not depend on the ruling Desktop Environment.
>//
>//
>case 0:
>  {
>     /** Child **/
>     close(d.fd[0]);
>     close_fds();
>
>     // Try to chdir, either to the requested directory or to the user's document path by default.
>     // We ignore errors - if you write a desktop file with Exec=foo and Path=/doesnotexist,
>     // we still want to execute `foo` even if the chdir() failed.
>     if (cwd && *cwd) {
>         (void)chdir(cwd);
>     } else {
>         const QByteArray docPath = QFile::encodeName(KGlobalSettings::documentPath());
>         (void)chdir(docPath.constData());
>     }
>
>     if( reset_env ) // KWRAPPER/SHELL
>     {
>
>         QList<QByteArray> unset_envs;
>         for( int tmp_env_count = 0;
>              environ[tmp_env_count];
>              tmp_env_count++)
>             unset_envs.append( environ[ tmp_env_count ] );
>         foreach(const QByteArray &tmp, unset_envs)
>         {
>             int pos = tmp.indexOf( '=' );
>             if( pos >= 0 )
>                 unsetenv( tmp.left( pos ));
>         }
>     }

Actions: View

Attachments on bug 844500: 601353