Attachment 601938 Details for Bug 785493 – php-horde-Horde-Cli-review.txt

php-horde-Horde-Cli-review.txt

php-horde-Horde-Cli-review.txt (text/plain), 8.02 KB, created by Remi Collet on 2012-08-02 12:33:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-08-02 12:33:52 UTC

Size: 8.02 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[-]: MUST Package contains desktop file if it is a GUI application.
>[-]: MUST Development files must be in a -devel package
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[-]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[!]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[-]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "UNKNOWN", "*No copyright* UNKNOWN" For detailed output of licensecheck
>     see file: /home/extras/SPECS/review/785493-php-horde-Horde-
>     Cli/licensecheck.txt
>[x]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Package is not relocatable.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: SHOULD Package functions as described.
>	php /usr/share/doc/pear/Horde_Cli/Horde/Cli/colors.php
>[x]: SHOULD Latest version is packaged.
>	1.0.4 is latest stable (2.0.0 is beta)
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>(un)install the package properly (un)register the extension
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (Horde_Cli-1.0.4.tgz)
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>
>==== PHP ====
>[x]: MUST Package requires php-common instead of php.
>
>Issues:
>Rpmlint
>-------
>Checking: php-horde-Horde-Cli-1.0.4-2.fc17.noarch.rpm
>          php-horde-Horde-Cli-1.0.4-2.fc17.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
>Cannot parse rpmlint output:
>Requires
>--------
>php-horde-Horde-Cli-1.0.4-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh  
>    /usr/bin/pear  
>    php-channel(pear.horde.org)  
>    php-common >= 5.2.0
>    php-pcre  
>    php-pear(PEAR) >= 1.7.0
>    php-pear(pear.horde.org/Horde_Support) < 2.0.0
>    php-pear(pear.horde.org/Horde_Translation) < 2.0.0
>    php-session  
>
>Provides
>--------
>php-horde-Horde-Cli-1.0.4-2.fc17.noarch.rpm:
>    
>    php-horde-Horde-Cli = 1.0.4-2.fc17
>    php-pear(pear.horde.org/Horde_Cli) = 1.0.4
>
>MD5-sum check
>-------------
>http://pear.horde.org/get/Horde_Cli-1.0.4.tgz :
>  MD5SUM this package     : 18630e80162d0d71a9add8a3ffb693eb
>  MD5SUM upstream package : 18630e80162d0d71a9add8a3ffb693eb
>
>$ phpci print --recursive --report extension Horde_Cli-1.0.4/lib
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              39
>  pcre                                                    4.0.0               3
>  session                                                 4.0.0               2
>  standard                                                4.0.0              50
>-------------------------------------------------------------------------------
>
>Requires:       php-pcre php-session
>Requires:       php-common >= 5.2.0
>
>$ phpci print --recursive --report class Horde_Cli-1.0.4/lib
>-------------------------------------------------------------------------------
>  CLASS                                 EXTENSION         VERSION         COUNT
>-------------------------------------------------------------------------------
>  Horde_Cli                                               4.0.0               1
>  Horde_Cli_Translation                                   4.0.0               4
>  Horde_Support_Backtrace                                 4.0.0               1
>  Horde_Translation                                       4.0.0               1
>-------------------------------------------------------------------------------
>
>Requires:       php-pear(pear.horde.org/Horde_Support) < 2.0.0
>Requires:       php-pear(pear.horde.org/Horde_Translation) < 2.0.0
>
>Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
>Command line :/bin/fedora-review -b 785493
>External plugins:
>
>============= ISSUES ============
>
>Could: localized php.ini is no more useful
>
>Could: requires php(language) >= 5.2.0 per new PHP Guildelines, 
>but this is fedora specific (for now), so php-common seems acceptable as you target both fedora/epel
>
>

Actions: View

Attachments on bug 785493: 601938