Attachment 601950 Details for Bug 785606 – php-horde-Horde-Test-review.txt

php-horde-Horde-Test-review.txt

php-horde-Horde-Test-review.txt (text/plain), 13.23 KB, created by Remi Collet on 2012-08-02 13:30:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-08-02 13:30:51 UTC

Size: 13.23 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[-]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[-]: MUST Package contains desktop file if it is a GUI application.
>[-]: MUST Development files must be in a -devel package
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[-]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf would be needed if support for EPEL5 is required
>[x]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "UNKNOWN" For detailed output of licensecheck see file:
>     /home/extras/SPECS/review/785606-php-horde-Horde-Test/licensecheck.txt
>	LGPLv2+
>[x]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[ ]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[!]: MUST Package installs properly.
>     Note: Installation errors (see attachment)
>[x]: MUST Package is not relocatable.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: No rpmlint messages.
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: SHOULD Package functions as described.
>	$ cd /usr/share/pear/test/Horde_Util/Horde/Util
>	$ phpunit .
>PHPUnit 3.6.11 by Sebastian Bergmann.
>......................................
>Time: 0 seconds, Memory: 4.25Mb
>OK (38 tests, 182 assertions)
>
>[x]: SHOULD Latest version is packaged.
>	1.3.0 is latest stable (2.0.0 is beta)
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD Scriptlets must be sane, if used.
>(un)install the package properly (un)register the extension
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (Horde_Test-1.3.0.tgz)
>[x]: SHOULD SourceX is a working URL.
>[-]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[-]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>	no test in this package
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>
>==== PHP ====
>[x]: MUST Package requires php-common instead of php.
>
>Rpmlint
>-------
>Checking: php-horde-Horde-Test-1.3.0-3.fc17.noarch.rpm
>          php-horde-Horde-Test-1.3.0-3.fc17.src.rpm
>2 packages and 0 specfiles checked; 0 errors, 0 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-horde-Horde-Test
>(none): E: no installed packages by name php-horde-Horde-Test
>0 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>Requires
>--------
>php-horde-Horde-Test-1.3.0-3.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh  
>    /usr/bin/pear  
>    php-channel(pear.horde.org)  
>    php-common >= 5.2.0
>    php-dom  
>    php-json  
>    php-pcre  
>    php-pdo  
>    php-pear(PEAR) >= 1.7.0
>    php-pear(pear.horde.org/Horde_Cli) < 2.0.0
>    php-pear(pear.horde.org/Horde_Log) < 2.0.0
>    php-pear(pear.horde.org/Horde_Support) < 2.0.0
>    php-pear(pear.horde.org/Horde_Util) < 2.0.0
>    php-pear(pear.phpunit.de/PHPUnit) >= 3.5.0
>    php-spl  
>
>Provides
>--------
>php-horde-Horde-Test-1.3.0-3.fc17.noarch.rpm:
>    
>    php-horde-Horde-Test = 1.3.0-3.fc17
>    php-pear(pear.horde.org/Horde_Test) = 1.3.0
>
>MD5-sum check
>-------------
>http://pear.horde.org/get/Horde_Test-1.3.0.tgz :
>  MD5SUM this package     : a6c91817891819b373be9850f7787148
>  MD5SUM upstream package : a6c91817891819b373be9850f7787148
>
>$ phpci print --recursive --report extension Horde_Test-1.3.0/lib/
>-------------------------------------------------------------------------------
>  EXTENSION                                        PECL   VERSION         COUNT
>-------------------------------------------------------------------------------
>  Core                                                    4.0.0              52
>  PDO                                           1.0.4dev  5.1.0               1
>  SPL                                                0.2  5.0.0               8
>  dom                                           20031129  5.0.0               4
>  json                                             1.2.1  5.2.0               1
>  pcre                                                    4.0.0               4
>  standard                                                4.0.0              63
>-------------------------------------------------------------------------------
>
>Requires:       php-pdo php-dom php-spl php-json php-pcre
>
>$ phpci print --recursive --report class Horde_Test-1.3.0/lib/
>-------------------------------------------------------------------------------
>  CLASS                                 EXTENSION         VERSION         COUNT
>-------------------------------------------------------------------------------
>  PDO                                   PDO               5.1.0               1
>  Exception                             SPL               5.1.0               4
>  InvalidArgumentException              SPL               5.1.0               1
>  RecursiveDirectoryIterator            SPL               5.1.2               1
>  RecursiveIteratorIterator             SPL               5.1.3               1
>  DOMDocument                           dom               5.0.0               4
>  Horde_Alarm_Null                                        4.0.0               1
>  Horde_Argv_Parser                                       4.0.0               1
>  Horde_Array                                             4.0.0               1
>  Horde_Cache                                             4.0.0               1
>  Horde_Cache_Storage_Mock                                4.0.0               1
>  Horde_Cli                                               4.0.0               1
>  Horde_Db_Adapter_Pdo_Sqlite                             4.0.0               1
>  Horde_Db_Migration_Migrator                             4.0.0               1
>  Horde_Exception_Wrapped                                 4.0.0               1
>  Horde_Group_Mock                                        4.0.0               1
>  Horde_History_Mock                                      4.0.0               1
>  Horde_Injector                                          4.0.0               2
>  Horde_Injector_TopLevel                                 4.0.0               1
>  Horde_Kolab_Storage_Factory                             4.0.0               1
>  Horde_Log_Handler_Mock                                  4.0.0               1
>  Horde_Log_Logger                                        4.0.0               1
>  Horde_Perms_Null                                        4.0.0               1
>  Horde_Prefs                                             4.0.0               1
>  Horde_Prefs_Storage_Null                                4.0.0               1
>  Horde_Session                                           4.0.0               1
>  Horde_SessionHandler                                    4.0.0               1
>  Horde_SessionHandler_Storage_Builtin                    4.0.0               1
>  Horde_Support_Backtrace                                 4.0.0               2
>  Horde_Test_AllTests                                     4.0.0               1
>  Horde_Test_Case                                         4.0.0               3
>  Horde_Test_Exception                                    4.0.0              18
>  Horde_Test_Factory_Alarm                                4.0.0               1
>  Horde_Test_Factory_Cache                                4.0.0               1
>  Horde_Test_Factory_Db                                   4.0.0               1
>  Horde_Test_Factory_Group                                4.0.0               1
>  Horde_Test_Factory_History                              4.0.0               1
>  Horde_Test_Factory_KolabStorage                         4.0.0               1
>  Horde_Test_Factory_Perms                                4.0.0               1
>  Horde_Test_Factory_Prefs                                4.0.0               1
>  Horde_Test_Factory_Registry                             4.0.0               1
>  Horde_Test_Factory_Session                              4.0.0               1
>  Horde_Test_Factory_Share                                4.0.0               1
>  Horde_Test_Functional                                   4.0.0               1
>  Horde_Test_Log                                          4.0.0               1
>  Horde_Test_Setup                                        4.0.0               1
>  Horde_Test_Stub_Cli                                     4.0.0               1
>  Horde_Test_Stub_Factory                                 4.0.0               1
>  Horde_Test_Stub_Parser                                  4.0.0               1
>  Horde_Test_Stub_Registry                                4.0.0               2
>  PHPUnit_Framework_TestCase                              4.0.0               1
>  PHPUnit_Framework_TestSuite                             4.0.0               1
>  PHPUnit_TextUI_TestRunner                               4.0.0               1
>-------------------------------------------------------------------------------
>
>    php-pear(pear.horde.org/Horde_Cli) < 2.0.0
>    php-pear(pear.horde.org/Horde_Log) < 2.0.0
>    php-pear(pear.horde.org/Horde_Support) < 2.0.0
>    php-pear(pear.horde.org/Horde_Util) < 2.0.0
>    php-pear(pear.phpunit.de/PHPUnit) >= 3.5.0
>
>
>Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
>Command line :/bin/fedora-review -b 785606
>External plugins:
>
>=========== ISSUES ===========
>
>Could: remove "localized" php.ini (no more useful)
>
>Could: requires php(language) >= 5.2.0 per new PHP Guildelines, 
>but this is fedora specific (for now), so php-common seems acceptable as you target both fedora/epel
>
>MUST Package installs properly:
>Need to wait for Horde_Log and Horde_Constrant to be approved before import
>
>Lot of used class are not listed in requires 
>As they are not listed by upstream, I think we can ommit them (optional)
>
>Ex, in /usr/share/pear/Horde/Test/Factory/Alarm.php
>        if (!class_exists('Horde_Alarm')) {
>            throw new Horde_Test_Exception('The "Horde_Alarm" class is unavailable!');
>        }
>        return new Horde_Alarm_Null();
>
>Package with tests which use the Horde_Test_Factory_Alarm will have to BR both Horde_Test and Horde_Alarm.
>

Actions: View

Attachments on bug 785606: 601950