Attachment 602569 Details for Bug 785371 – fedora-review review template

fedora-review review template

speed-dreams-review.txt (text/plain), 13.53 KB, created by Alec Leamas on 2012-08-06 19:53:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alec Leamas

Created: 2012-08-06 19:53:40 UTC

Size: 13.53 KB

patch

obsolete

>
>Package Review
>==============
>
>==== C/C++ ====
>[x]: MUST Header files in -devel subpackage, if present.
>[x]: MUST Package does not contain any libtool archives (.la)
>[x]: MUST Package does not contain kernel modules.
>[x]: MUST Package contains no static executables.
>[x]: MUST Rpath absent or only used for internal libs.
>[-]: MUST Development (unversioned) .so files in -devel subpackage, if
>     present.
>     Lot's of unversioned, private libs in /usr/lib/games/speed-
>     dreams-2. Being private and not provided this is OK.
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[x]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Buildroot is not present
>     Note: Unless packager wants to package for EPEL5 this is fine
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean would be needed if support for EPEL is required
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[-]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package contains desktop file if it is a GUI application.
>[x]: MUST Package installs a %{name}.desktop using desktop-file-install if
>     there is such a file.
>[x]: MUST Development files must be in a -devel package
>[-]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[x]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Fully versioned dependency in subpackages, if present.
>[x]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[-]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "LGPL (v2 or later)", "*No copyright* UNKNOWN", "GPL (v2 or later) LGPL
>     (v2 or later)", "UNKNOWN", "GPL (v2 or later)", "*No copyright* GPL (v2
>     or later)", "*No copyright* GENERATED FILE" For detailed output of
>     licensecheck see file: /mnt/home/mk/sd/speed-dreams/licensecheck.txt
>[x]: MUST License file installed when any subpackage combination is installed.
>[x]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Package is not relocatable.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[x]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[-]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[?]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD SourceX / PatchY prefixed with %{name}.
>[x]: SHOULD SourceX is a working URL.
>[x]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[?]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>Rpmlint
>-------
>Checking: speed-dreams-2.0.0-2.post_r4810.fc16.src.rpm
>          speed-dreams-robots-base-2.0.0-2.post_r4810.fc16.i686.rpm
>          speed-dreams-2.0.0-2.post_r4810.fc16.i686.rpm
>          speed-dreams-devel-2.0.0-2.post_r4810.fc16.i686.rpm
>          speed-dreams-debuginfo-2.0.0-2.post_r4810.fc16.i686.rpm
>speed-dreams.src:5: W: macro-in-comment %src_release
>speed-dreams.src: W: invalid-url Source4: speed-dreams-src-unmaintained-2.0.0-post-r4810.tar.xz
>speed-dreams.src: W: invalid-url Source3: speed-dreams-src-more-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz
>speed-dreams.src: W: invalid-url Source2: speed-dreams-src-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz
>speed-dreams.src: W: invalid-url Source1: speed-dreams-src-wip-cars-and-tracks-2.0.0-post-r4810.tar.xz
>speed-dreams.src: W: invalid-url Source0: speed-dreams-src-base-2.0.0-post-r4810.tar.xz
>-->  OK, properly commented on how to build the sources
>
>speed-dreams-devel.i686: W: no-documentation
>speed-dreams-robots-base.i686: W: no-documentation
>--> Always installed with base package, which has the docs.
>
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgfclient.so libtgfclient.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/librobottools.so librobottools.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgf.so libtgf.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/liblearning.so liblearning.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libraceengine.so libraceengine.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libnetworking.so libnetworking.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgfdata.so libtgfdata.so
>--> Refers to private libs which not are provided, and can thus be ignored.
>
>speed-dreams.i686: W: shared-lib-calls-exit /usr/lib/games/speed-dreams-2/lib/libtgf.so exit@GLIBC_2.0
>speed-dreams.i686: W: shared-lib-calls-exit /usr/lib/games/speed-dreams-2/lib/libtgfclient.so exit@GLIBC_2.0
>--> http://sourceforge.net/apps/trac/speed-dreams/ticket/603
>
>speed-dreams.i686: W: manual-page-warning /usr/share/man/man6/sd2-accc.6.gz 42: a space character is not allowed in an escape name
>--> ignored, this is minor. Really.
>
>5 packages and 0 specfiles checked; 7 errors, 11 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint speed-dreams speed-dreams-debuginfo
>speed-dreams.i686: I: enchant-dictionary-not-found en_US
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgfclient.so libtgfclient.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/liblearning.so liblearning.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/librobottools.so librobottools.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgf.so libtgf.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libnetworking.so libnetworking.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libtgfdata.so libtgfdata.so
>speed-dreams.i686: E: invalid-soname /usr/lib/games/speed-dreams-2/lib/libraceengine.so libraceengine.so
>--> OK, see above
>
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/libtgfdata.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/libnetworking.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/libtgfclient.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/liblearning.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/librobottools.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/libtgf.so linux-gate.so.1
>speed-dreams.i686: W: unused-direct-shlib-dependency /usr/lib/games/speed-dreams-2/lib/libraceengine.so linux-gate.so.1
>--> Only remaining after applyiung -Wl,-as-needed. linux-gate (the kernel
>    interface) isn't much bloat and can be ignored.
>speed-dreams.i686: W: shared-lib-calls-exit /usr/lib/games/speed-dreams-2/lib/libtgfclient.so exit@GLIBC_2.0
>speed-dreams.i686: W: shared-lib-calls-exit /usr/lib/games/speed-dreams-2/lib/libtgf.so exit@GLIBC_2.0
>--> See above
>2 packages and 0 specfiles checked; 7 errors, 9 warnings.
># echo 'rpmlint-done:'
>
>Requires
>--------
>speed-dreams-robots-base-2.0.0-2.post_r4810.fc16.i686.rpm (rpmlib, GLIBC filtered):
>
>    speed-dreams
>    speed-dreams(x86-32) = 2.0.0-2.post_r4810.fc16
>
>speed-dreams-2.0.0-2.post_r4810.fc16.i686.rpm (rpmlib, GLIBC filtered):
>
>    libFreeSOLID.so.0
>    libGL.so.1
>    libGLU.so.1
>    libICE.so.6
>    libSDL-1.2.so.0
>    libSM.so.6
>    libX11.so.6
>    libXext.so.6
>    libXrandr.so.2
>    libc.so.6
>    libdl.so.2
>    libenet-1.2.1.so
>    libexpat.so.1
>    libgcc_s.so.1
>    libgcc_s.so.1(GCC_3.0)
>    libjpeg.so.62
>    libjpeg.so.62(LIBJPEG_6.2)
>    libm.so.6
>    libopenal.so.1
>    libplibjs.so.1.8.5
>    libplibsg.so.1.8.5
>    libplibsl.so.1.8.5
>    libplibssg.so.1.8.5
>    libplibssgaux.so.1.8.5
>    libplibul.so.1.8.5
>    libpng12.so.0
>    libpng12.so.0(PNG12_0)
>    libpthread.so.0
>    libstdc++.so.6
>    libstdc++.so.6(CXXABI_1.3)
>    libz.so.1
>    opengl-games-utils
>    rtld(GNU_HASH)
>
>speed-dreams-devel-2.0.0-2.post_r4810.fc16.i686.rpm (rpmlib, GLIBC filtered):
>
>    speed-dreams(x86-32) = 2.0.0-2.post_r4810.fc16
>
>speed-dreams-debuginfo-2.0.0-2.post_r4810.fc16.i686.rpm (rpmlib, GLIBC filtered):
>
>
>Provides
>--------
>speed-dreams-robots-base-2.0.0-2.post_r4810.fc16.i686.rpm:
>
>    speed-dreams-robots-base = 2.0.0-2.post_r4810.fc16
>    speed-dreams-robots-base(x86-32) = 2.0.0-2.post_r4810.fc16
>
>speed-dreams-2.0.0-2.post_r4810.fc16.i686.rpm:
>
>    speed-dreams = 2.0.0-2.post_r4810.fc16
>    speed-dreams(x86-32) = 2.0.0-2.post_r4810.fc16
>
>speed-dreams-devel-2.0.0-2.post_r4810.fc16.i686.rpm:
>
>    speed-dreams-devel = 2.0.0-2.post_r4810.fc16
>    speed-dreams-devel(x86-32) = 2.0.0-2.post_r4810.fc16
>
>speed-dreams-debuginfo-2.0.0-2.post_r4810.fc16.i686.rpm:
>
>    speed-dreams-debuginfo = 2.0.0-2.post_r4810.fc16
>    speed-dreams-debuginfo(x86-32) = 2.0.0-2.post_r4810.fc16
>
>MD5-sum check
>-------------
>Using local file /mnt/home/mk/sd/speed-dreams-src-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz as upstream
>file:///mnt/home/mk/sd/speed-dreams-src-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz :
>  MD5SUM this package     : 4daa2517e4828e23c64ff7cd6ef62bc1
>  MD5SUM upstream package : 4daa2517e4828e23c64ff7cd6ef62bc1
>Using local file /mnt/home/mk/sd/speed-dreams-src-more-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz as upstream
>file:///mnt/home/mk/sd/speed-dreams-src-more-hq-cars-and-tracks-2.0.0-post-r4810.tar.xz :
>  MD5SUM this package     : 383ad3234b686af86351456150daf360
>  MD5SUM upstream package : 383ad3234b686af86351456150daf360
>Using local file /mnt/home/mk/sd/speed-dreams-src-base-2.0.0-post-r4810.tar.xz as upstream
>file:///mnt/home/mk/sd/speed-dreams-src-base-2.0.0-post-r4810.tar.xz :
>  MD5SUM this package     : fbc94616f05992a8c490b8dd5a9ad398
>  MD5SUM upstream package : fbc94616f05992a8c490b8dd5a9ad398
>Using local file /mnt/home/mk/sd/speed-dreams-src-wip-cars-and-tracks-2.0.0-post-r4810.tar.xz as upstream
>file:///mnt/home/mk/sd/speed-dreams-src-wip-cars-and-tracks-2.0.0-post-r4810.tar.xz :
>  MD5SUM this package     : 27dc93a1e0fe134a607977b82e30fb55
>  MD5SUM upstream package : 27dc93a1e0fe134a607977b82e30fb55
>Using local file /mnt/home/mk/sd/speed-dreams-src-unmaintained-2.0.0-post-r4810.tar.xz as upstream
>file:///mnt/home/mk/sd/speed-dreams-src-unmaintained-2.0.0-post-r4810.tar.xz :
>  MD5SUM this package     : d21f28352c38750fd1682c3f78c5f3de
>  MD5SUM upstream package : d21f28352c38750fd1682c3f78c5f3de
>
>
>Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
>Command line :/usr/bin/fedora-review -n speed-dreams -m fedora-16-i386-rpmfusion_free-updates-testing
>External plugins:

Actions: View

Attachments on bug 785371: 558188 | 558189 | 558190 | 558191 | 559905 | 560316 | 597314 | 597315 | 602569 | 604039