Attachment 604740 Details for Bug 770000 – function cleanup

[patch] function cleanup

1 (text/plain), 1.19 KB, created by Dave Young on 2012-08-16 01:53:04 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Young

Created: 2012-08-16 01:53:04 UTC

Size: 1.19 KB

patch

obsolete

>Add a function to check ko to be excluded
>
>Resolves: bz770000
>
>We internally exclude some kernel modules in kdumprd, now make the exclude
>module list a global variable and create a function to check if a module should
>be excluded or not.
>
>This is a cleanup and improvement of original code.
>
>Signed-off-by: Dave Young <dyoung@redhat.com>
>---
> mkdumprd |   16 +++++++++++++---
> 1 file changed, 13 insertions(+), 3 deletions(-)
>
>--- kexec-tools.orig/mkdumprd
>+++ kexec-tools/mkdumprd
>@@ -2597,12 +2597,22 @@ cat >> $MNTIMAGE/etc/passwd << EOF
> root:x:0:0:root:/root:/bin/bash
> EOF
> 
>+default_exclude_modules="snd soundcore cfg80211 mac80211 iwl"
>+
>+# $1: module basename
>+exclude_module() {
>+    local i
>+
>+    for i in $default_exclude_modules; do
>+        [[ "$1" =~ "$i" ]] && return 0
>+    done
>+    return 1
>+}
>+
> mkdir -p $MNTIMAGE/lib/modules/$kernel
> for MODULE in $MODULES; do
>     _base_name=$(basename $MODULE)
>-    if [[ "$_base_name" =~ "snd" ]] || [[ "$_base_name" =~ "soundcore" ]] ||
>-    [[ "$_base_name" =~ "cfg80211" ]] || [[ "$_base_name" =~ "mac80211" ]] ||
>-    [[ "$_base_name" =~ "iwl" ]]; then
>+    if exclude_module $_base_name; then
>         MODULES=${MODULES/$MODULE/}
>         continue
>     fi

Actions: View | Diff

Attachments on bug 770000: 549252 | 549253 | 604172 | 604740 | 604741