Attachment 604977 Details for Bug 848353 – fedora-review result for python-pthreading

fedora-review result for python-pthreading

file_848353.txt (text/plain), 8.69 KB, created by Pierre on 2012-08-16 16:33:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Pierre

Created: 2012-08-16 16:33:14 UTC

Size: 8.69 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[ ]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[ ]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>[ ]: MUST Package contains no bundled libraries.
>[ ]: MUST Changelog in prescribed format.
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>[ ]: MUST Sources contain only permissible code or content.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: Note: defattr macros not found. They would be needed for EPEL5
>[ ]: MUST Macros in Summary, %description expandable at SRPM build time.
>[ ]: MUST Package contains desktop file if it is a GUI application.
>[ ]: MUST Development files must be in a -devel package
>[ ]: MUST Package requires other packages for directories it uses.
>[ ]: MUST Package uses nothing in %doc for runtime.
>[ ]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[ ]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>[ ]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[ ]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "*No copyright* UNKNOWN", "GPL (v2 or later)" For detailed output of
>     licensecheck see file: /home/pierre/rpmbuild/SPECS/python-
>     pthreading/licensecheck.txt
>[ ]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[ ]: MUST Package is named according to the Package Naming Guidelines.
>[ ]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[ ]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[ ]: MUST Package must own all directories that it creates.
>[ ]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[ ]: MUST Package is not relocatable.
>[ ]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[!]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>     Note: Upstream MD5sum check error, diff is in /home/pierre/rpmbuild/SPECS
>     /python-pthreading/diff.txt
>[ ]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[ ]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[ ]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[ ]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: SHOULD Package functions as described.
>[ ]: SHOULD Latest version is packaged.
>[ ]: SHOULD Package does not include license text files separate from
>     upstream.
>[ ]: SHOULD Patches link to upstream bugs/comments/lists or are otherwise
>     justified.
>[!]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Patch1 (01-COPYING-and-tests.patch) Source0
>     (pthreading-0.1.1.tar.gz)
>[x]: SHOULD SourceX is a working URL.
>[ ]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: SHOULD %check is present and all tests pass.
>[ ]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>Issues:
>[!]: MUST Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#BuildRoot_tag
>[!]: MUST Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#.25clean
>[!]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>See: None
>[!]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>     Note: Upstream MD5sum check error, diff is in /home/pierre/rpmbuild/SPECS
>     /python-pthreading/diff.txt
>See: http://fedoraproject.org/wiki/Packaging/SourceURL
>
>Rpmlint
>-------
>Checking: python-pthreading-0.1.1-1.fc17.i686.rpm
>          python-pthreading-0.1.1-1.fc17.src.rpm
>          python-pthreading-debuginfo-0.1.1-1.fc17.i686.rpm
>python-pthreading.i686: W: spelling-error Summary(en_US) libpthread -> threadlike
>python-pthreading.i686: W: spelling-error %description -l en_US libpthread -> threadlike
>python-pthreading.i686: W: spelling-error %description -l en_US performence -> performance, performer, performed
>python-pthreading.i686: W: spelling-error %description -l en_US x's -> X's, ex's, xi's
>python-pthreading.i686: E: no-binary
>python-pthreading.i686: E: incorrect-fsf-address /usr/share/doc/python-pthreading-0.1.1/COPYING
>python-pthreading.src: W: spelling-error Summary(en_US) libpthread -> threadlike
>python-pthreading.src: W: spelling-error %description -l en_US libpthread -> threadlike
>python-pthreading.src: W: spelling-error %description -l en_US performence -> performance, performer, performed
>python-pthreading.src: W: spelling-error %description -l en_US x's -> X's, ex's, xi's
>python-pthreading.src: W: file-size-mismatch pthreading-0.1.1.tar.gz = 3448, http://pypi.python.org/packages/source/p/pthreading/pthreading-0.1.1.tar.gz = 3449
>python-pthreading-debuginfo.i686: E: empty-debuginfo-package
>3 packages and 0 specfiles checked; 3 errors, 9 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint python-pthreading-debuginfo
>python-pthreading-debuginfo.i686: I: enchant-dictionary-not-found en_US
>python-pthreading-debuginfo.i686: E: empty-debuginfo-package
>1 packages and 0 specfiles checked; 1 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>Requires
>--------
>python-pthreading-0.1.1-1.fc17.i686.rpm (rpmlib, GLIBC filtered):
>    
>    python(abi) = 2.7
>
>python-pthreading-debuginfo-0.1.1-1.fc17.i686.rpm (rpmlib, GLIBC filtered):
>    
>
>Provides
>--------
>python-pthreading-0.1.1-1.fc17.i686.rpm:
>    
>    python-pthreading = 0.1.1-1.fc17
>    python-pthreading(x86-32) = 0.1.1-1.fc17
>
>python-pthreading-debuginfo-0.1.1-1.fc17.i686.rpm:
>    
>    python-pthreading-debuginfo = 0.1.1-1.fc17
>    python-pthreading-debuginfo(x86-32) = 0.1.1-1.fc17
>
>MD5-sum check
>-------------
>http://pypi.python.org/packages/source/p/pthreading/pthreading-0.1.1.tar.gz :
>  MD5SUM this package     : 94ce9aa85d34759fabc71fbe90a58f40
>  MD5SUM upstream package : 4ba7f5d60b0595ec82192746295bd5b0
>diff -r also reports differences
>
>
>Generated by fedora-review 0.2.0 (53cc903) last change: 2012-07-09
>Command line :/usr/bin/fedora-review -u https://bugzilla.redhat.com/show_bug.cgi?id=848353
>External plugins:

Actions: View

Attachments on bug 848353: 604977 | 605647