Attachment 607867 Details for Bug 846702 – perf session: Skip event correctly for unknown id/machine

perf session: Skip event correctly for unknown id/machine

02-perf-session-Skip-event-correctly-for-unknown-id-or-machine.patch (text/plain), 1.56 KB, created by IBM Bug Proxy on 2012-08-29 11:04:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: IBM Bug Proxy

Created: 2012-08-29 11:04:42 UTC

Size: 1.56 KB

patch

obsolete

>Backport of commit 6782206b5dfece4c51f587b3ca1540a4027f87dd
>Author: Jiri Olsa <jolsa@redhat.com>
>Date:   Thu Apr 12 14:21:01 2012 +0200
>
>perf session: Skip event correctly for unknown id/machine
>
>In case the perf_session__process_event function fails, we estimate the
>next event offset.
>
>This is not necessary for sample event failing on unknown ID or machine.
>In such case we know proper size of the event, so we dont need to guess.
>Also failure statistics are updated correctly so we don't miss any
>information.
>
>Forcing perf_session__process_event to return 0 in case of unknown ID or
>machine.
>
>Signed-off-by: Jiri Olsa <jolsa@redhat.com>
>Cc: Corey Ashford <cjashfor@linux.vnet.ibm.com>
>Cc: Frederic Weisbecker <fweisbec@gmail.com>
>Cc: Ingo Molnar <mingo@elte.hu>
>Cc: Paul Mackerras <paulus@samba.org>
>Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>
>Link: http://lkml.kernel.org/r/1334233262-5679-3-git-send-email-jolsa@redhat.com
>Signed-off-by: Arnaldo Carvalho de Melo <acme@redhat.com>
>---
>--- linux-2.6.32-257.el6.bz80818.x86_64/tools/perf/util/~session.c	2012-04-17 13:21:02.677045441 +0530
>+++ linux-2.6.32-257.el6.bz80818.x86_64/tools/perf/util/session.c	2012-04-17 13:21:17.349934103 +0530
>@@ -794,11 +794,11 @@ static int perf_session_deliver_event(st
> 		dump_sample(session, event, sample);
> 		if (evsel == NULL) {
> 			++session->hists.stats.nr_unknown_id;
>-			return -1;
>+			return 0;
> 		}
> 		if (machine == NULL) {
> 			++session->hists.stats.nr_unprocessable_samples;
>-			return -1;
>+			return 0;
> 		}
> 		return tool->sample(tool, event, sample, evsel, machine);
> 	case PERF_RECORD_MMAP:

Actions: View

Attachments on bug 846702: 607866 | 607867