Attachment 608524 Details for Bug 817196 – vim-7.3-py_ssize_t.patch

[patch] vim-7.3-py_ssize_t.patch

vim-7.3-py_ssize_t.patch (text/plain), 1.13 KB, created by Aron Griffis on 2012-08-31 13:43:16 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aron Griffis

Created: 2012-08-31 13:43:16 UTC

Size: 1.13 KB

patch

obsolete

>Date: Mon, 27 Aug 2012 20:08:51 -0700
>From: Sean Estabrooks <seanl...@sympatico.ca>
>To: vim-dev@vim.org
>Message-ID: <BLU0-SMTP4018EAD8F2DF00E62E043BAAEA10@phx.gbl>
>Subject: [PATCH] Use proper return type when handling python output
>
>This removes the need for older code that avoided a crash
>but meant that output wasn't displayed.
>---
> src/if_py_both.h | 7 +------
> 1 file changed, 1 insertion(+), 6 deletions(-)
>
>diff --git a/src/if_py_both.h b/src/if_py_both.h
>index 60375d1..931ecb9 100644
>--- a/src/if_py_both.h
>+++ b/src/if_py_both.h
>@@ -74,18 +74,13 @@ static struct PyMethodDef OutputMethods[] = {
>     static PyObject *
> OutputWrite(PyObject *self, PyObject *args)
> {
>-    int len;
>+    Py_ssize_t len;
>     char *str = NULL;
>     int error = ((OutputObject *)(self))->error;
> 
>     if (!PyArg_ParseTuple(args, "et#", ENC_OPT, &str, &len))
> 	return NULL;
> 
>-    /* TODO: This works around a gcc optimizer problem and avoids Vim
>-     * from crashing.  Should find a real solution. */
>-    if (str == NULL)
>-	return NULL;
>-
>     Py_BEGIN_ALLOW_THREADS
>     Python_Lock_Vim();
>     writer((writefn)(error ? emsg : msg), (char_u *)str, len);
>-- 
>1.7.11.4
>

Actions: View | Diff

Attachments on bug 817196: 580900 | 603642 | 608523 | 608524