Attachment 609604 Details for Bug 835633 – [PATCH] Handle failures in the various setups before --shell

[patch] [PATCH] Handle failures in the various setups before --shell

0001-Handle-failures-in-the-various-setups-before-shell.patch (text/plain), 1.24 KB, created by Mathieu Bridon on 2012-09-04 09:11:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Mathieu Bridon

Created: 2012-09-04 09:11:24 UTC

Size: 1.24 KB

patch

obsolete

>From b150af84d263e44f8ce8229ddb92fe88f3673073 Mon Sep 17 00:00:00 2001
>From: Mathieu Bridon <bochecha@fedoraproject.org>
>Date: Tue, 4 Sep 2012 17:05:57 +0800
>Subject: [PATCH] Handle failures in the various setups before --shell
>
>If something fails before we start the 'shell' state, then
>we can't finish the state when catching the exception, which
>makes the rest of the error handling fail.
>
>This commit makes sure we properly handle exceptions in the
>setup, and then exceptions when running the shell.
>---
> py/mockbuild/backend.py |    6 ++++++
> 1 files changed, 6 insertions(+), 0 deletions(-)
>
>diff --git a/py/mockbuild/backend.py b/py/mockbuild/backend.py
>index 31e768f..e00d3de 100644
>--- a/py/mockbuild/backend.py
>+++ b/py/mockbuild/backend.py
>@@ -712,6 +712,12 @@ class Root(object):
>             self._setupFiles()
>             log.debug("shell: mounting all filesystems")
>             self._mountall()
>+        except Exception as e:
>+            log.error(e)
>+            self.unlockBuildRoot()
>+            return mockbuild.exception.RootError(e).resultcode
>+
>+        try:
>             self.start("shell")
>             ret = mockbuild.util.doshell(chrootPath=self.makeChrootPath(), 
>                                          environ=self.env,
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 835633: 606100 | 609603 | 609604 | 609624