Attachment 610095 Details for Bug 853308 – Patch to address the problem

[patch] Patch to address the problem

fix-efigrub.patch (text/plain), 3.50 KB, created by Peter Jones on 2012-09-05 16:56:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Peter Jones

Created: 2012-09-05 16:56:55 UTC

Size: 3.50 KB

patch

obsolete

>commit 208106a19046e35207cc3f77576b4a3ab902bec4
>Author: Peter Jones <pjones@redhat.com>
>Date:   Wed Sep 5 12:17:49 2012 -0400
>
>    Don't depend on storage or instClass in EFIGRUB
>    
>    Resolves: rhbz#853308
>
>diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
>index e9ffbf1..22e4031 100644
>--- a/pyanaconda/bootloader.py
>+++ b/pyanaconda/bootloader.py
>@@ -1551,7 +1551,11 @@ class EFIGRUB(GRUB2):
> 
>     @property
>     def _config_dir(self):
>-        return "efi/EFI/%s" % (self.storage.anaconda.instClass.efi_dir,)
>+        return "efi/EFI/%s" % (self.efi_dir,)
>+
>+    def __init__(self, platform=None):
>+        super(EFIGRUB, self).__init__(platform=platform)
>+        self.efi_dir = 'BOOT'
> 
>     def efibootmgr(self, *args, **kwargs):
>         if kwargs.pop("capture", False):
>@@ -2132,7 +2136,7 @@ def writeSysconfigKernel(storage, version):
>     f.write("DEFAULTKERNEL=%s\n" % kernel)
>     f.close()
> 
>-def writeBootLoader(storage, payload):
>+def writeBootLoader(storage, payload, instClass):
>     """ Write bootloader configuration to disk.
> 
>         When we get here, the bootloader will already have a default linux
>@@ -2165,6 +2169,8 @@ def writeBootLoader(storage, payload):
>                                          short=base_short_label)
>     storage.bootloader.add_image(default_image)
>     storage.bootloader.default = default_image
>+    if hasattr(storage.bootloader, 'efi_dir'):
>+        storage.bootloader.efi_dir = instClass.efi_dir
> 
>     # write out /etc/sysconfig/kernel
>     writeSysconfigKernel(storage, version)
>diff --git a/pyanaconda/install.py b/pyanaconda/install.py
>index d639df3..36f4831 100644
>--- a/pyanaconda/install.py
>+++ b/pyanaconda/install.py
>@@ -76,7 +76,7 @@ def doInstall(storage, payload, ksdata, instClass):
> 
>     # Do bootloader.
>     with progress_report(_("Installing bootloader")):
>-        writeBootLoader(storage, payload)
>+        writeBootLoader(storage, payload, instClass)
> 
>     # Now run the execute methods of ksdata that require an installed system
>     # to be present first.
>
>commit 3108e9cf1aee919afb060f2fe5e52d6c69c5b339
>Author: Peter Jones <pjones@redhat.com>
>Date:   Wed Sep 5 11:51:04 2012 -0400
>
>    Use self.stage1_device where appropriate in EFIGRUB.
>    
>    This gets rid of storage references.
>    
>    Related: rhbz#853308
>
>diff --git a/pyanaconda/bootloader.py b/pyanaconda/bootloader.py
>index 04b4066..e9ffbf1 100644
>--- a/pyanaconda/bootloader.py
>+++ b/pyanaconda/bootloader.py
>@@ -1592,15 +1592,14 @@ class EFIGRUB(GRUB2):
>         return ret.replace('/', '\\')
> 
>     def add_efi_boot_target(self):
>-        boot_efi = self.storage.mountpoints["/boot/efi"]
>-        if boot_efi.type == "partition":
>-            boot_disk = boot_efi.disk
>-            boot_part_num = boot_efi.partedPartition.number
>-        elif boot_efi.type == "mdarray":
>+        if self.stage1_device.type == "partition":
>+            boot_disk = self.stage1_device.disk
>+            boot_part_num = self.stage1_device.partedPartition.number
>+        elif self.stage1_device.type == "mdarray":
>             # FIXME: I'm just guessing here. This probably needs the full
>             #        treatment, ie: multiple targets for each member.
>-            boot_disk = boot_efi.parents[0].disk
>-            boot_part_num = boot_efi.parents[0].partedPartition.number
>+            boot_disk = self.stage1_device.parents[0].disk
>+            boot_part_num = self.stage1_device.parents[0].partedPartition.number
>         boot_part_num = str(boot_part_num)
> 
>         rc = self.efibootmgr("-c", "-w", "-L", productName,

Actions: View | Diff

Attachments on bug 853308: 608354 | 608355 | 608356 | 608357 | 608358 | 608359 | 608360 | 608361 | 608362 | 608363 | 608364 | 608365 | 608366 | 610093 | 610095