Attachment 610851 Details for Bug 839788 – modified patch

[patch] modified patch

perl-5.10.1-839788.patch (text/plain), 1008 bytes, created by Will Saxon on 2012-09-07 22:28:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Will Saxon

Created: 2012-09-07 22:28:46 UTC

Size: 1008 bytes

patch

obsolete

>diff --git a/sv.c b/sv.c
>index fb82caf..ed4be5f 100644
>--- a/sv.c
>+++ b/sv.c
>@@ -5419,7 +5419,8 @@ Perl_sv_clear(pTHX_ register SV *const sv)
>		if (destructor
> 			/* Don't bother calling an empty destructor */
> 			&& (CvISXSUB(destructor)
>-			|| CvSTART(destructor)->op_next->op_type != OP_LEAVESUB))
>+			|| (CvSTART(destructor)
>+			    && (CvSTART(destructor)->op_next->op_type != OP_LEAVESUB))))
> 		{
> 		    SV* const tmpref = newRV(sv);
> 	            SvREADONLY_on(tmpref);   /* DESTROY() could be naughty */
>diff --git a/t/op/method.t b/t/op/method.t
>index afa8cfb..d2914c4 100644
>--- a/t/op/method.t
>+++ b/t/op/method.t
>@@ -10,7 +10,7 @@ BEGIN {
>     require "test.pl";
> }
> 
>-print "1..78\n";
>+print "1..79\n";
> 
> @A::ISA = 'B';
> @B::ISA = 'C';
>@@ -292,3 +292,12 @@ EOT
> 	"check if UNIVERSAL::AUTOLOAD works",
>     );
> }
>+{
>+    fresh_perl_is(<<'EOT',
>+sub M::DESTROY; bless {}, "M" ; print "survived\n";
>+EOT
>+    "survived",
>+    {},
>+	"no crash with a declared but missing DESTROY method"
>+    );
>+}

Actions: View | Diff

Attachments on bug 839788: 598738 | 610850 | 610851