Attachment 612642 Details for Bug 853463 – Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09

Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09

php-redis-review.txt (text/plain), 8.71 KB, created by Shawn Iwinski on 2012-09-13 20:57:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Shawn Iwinski

Created: 2012-09-13 20:57:50 UTC

Size: 8.71 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>- = N/A
>x = Pass
>! = Fail
>? = Not evaluated
>
>
>
>==== C/C++ ====
>[x]: MUST Header files in -devel subpackage, if present.
>[x]: MUST Package does not contain any libtool archives (.la)
>[x]: MUST Package does not contain kernel modules.
>[x]: MUST Package contains no static executables.
>[x]: MUST Rpath absent or only used for internal libs.
>[x]: MUST Development (unversioned) .so files in -devel subpackage, if
>     present.
>     Note: Unversioned so-files in non-devel package (fix or explain):php-
>     redis-2.2.2-5.git6f7087f.fc17.x86_64.rpm : /usr/lib64/php-
>     zts/modules/redis.so php-redis-2.2.2-5.git6f7087f.fc17.x86_64.rpm :
>     /usr/lib64/php/modules/redis.so
>
>
>==== Generic ====
>[x]: EXTRA Rpmlint is run on all installed packages.
>     Note: No rpmlint messages.
>[x]: EXTRA Spec file according to URL is the same as in SRPM.
>[x]: MUST Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: MUST Package successfully compiles and builds into binary rpms on at
>     least one supported primary architecture.
>[x]: MUST %build honors applicable compiler flags or justifies otherwise.
>[x]: MUST All build dependencies are listed in BuildRequires, except for any
>     that are listed in the exceptions section of Packaging Guidelines.
>[x]: MUST Package contains no bundled libraries.
>[x]: MUST Changelog in prescribed format.
>[x]: MUST Sources contain only permissible code or content.
>[x]: MUST %config files are marked noreplace or the reason is justified.
>[x]: MUST Each %files section contains %defattr if rpm < 4.4
>     Note: defattr(....) present in %files section. This is OK if packaging
>     for EPEL5. Otherwise not needed
>
>     Note from packager: EPEL-5 not targeted (redis requires igbinary which
>     requires php 5.2) but I want to keep old packaging stuff (buildroot,
>     clean, ...) to make backports possible.
>
>[x]: MUST Macros in Summary, %description expandable at SRPM build time.
>[x]: MUST Package contains desktop file if it is a GUI application.
>[x]: MUST Development files must be in a -devel package
>[x]: MUST Package requires other packages for directories it uses.
>[x]: MUST Package uses nothing in %doc for runtime.
>[x]: MUST Package is not known to require ExcludeArch.
>[x]: MUST Permissions on files are set properly.
>[x]: MUST Package does not contain duplicates in %files.
>[x]: MUST Package complies to the Packaging Guidelines
>[x]: MUST Spec file lacks Packager, Vendor, PreReq tags.
>[x]: MUST Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf is only needed if supporting EPEL5
>
>     Note from packager: EPEL-5 not targeted (redis requires igbinary which
>     requires php 5.2) but I want to keep old packaging stuff (buildroot,
>     clean, ...) to make backports possible.
>
>[x]: MUST Large documentation files are in a -doc subpackage, if required.
>[x]: MUST If (and only if) the source package includes the text of the
>     license(s) in its own file, then that file, containing the text of the
>     license(s) for the package is included in %doc.
>[x]: MUST License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "PHP (v3.01)", "GPL (v2 or later)" For detailed output of licensecheck
>     see file: /home/siwinski/projects/fedora/reviews/853463-php-
>     redis/licensecheck.txt
>[x]: MUST Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: MUST Package is named using only allowed ascii characters.
>[x]: MUST Package is named according to the Package Naming Guidelines.
>[x]: MUST No %config files under /usr.
>[x]: MUST Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: MUST Package obeys FHS, except libexecdir and /usr/target.
>[x]: MUST If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: MUST Package must own all directories that it creates.
>[x]: MUST Package does not own files or directories owned by other packages.
>[x]: MUST Package installs properly.
>[x]: MUST Package is not relocatable.
>[x]: MUST Requires correct, justified where necessary.
>[x]: MUST Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: MUST Sources used to build the package match the upstream source, as
>     provided in the spec URL.
>[x]: MUST Spec file is legible and written in American English.
>[x]: MUST Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[x]: MUST Package contains systemd file(s) if in need.
>[x]: MUST File names are valid UTF-8.
>[x]: MUST Useful -debuginfo package or justification otherwise.
>[x]: SHOULD Reviewer should test that the package builds in mock.
>[x]: SHOULD Buildroot is not present
>     Note: Buildroot is not needed unless packager plans to package for EPEL5
>
>     Note from packager: EPEL-5 not targeted (redis requires igbinary which
>     requires php 5.2) but I want to keep old packaging stuff (buildroot,
>     clean, ...) to make backports possible.
>
>[x]: SHOULD Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: Clean is needed only if supporting EPEL5
>
>     Note from packager: EPEL-5 not targeted (redis requires igbinary which
>     requires php 5.2) but I want to keep old packaging stuff (buildroot,
>     clean, ...) to make backports possible.
>
>[x]: SHOULD If the source package does not include license text(s) as a
>     separate file from upstream, the packager SHOULD query upstream to
>     include it.
>[x]: SHOULD Dist tag is present.
>[x]: SHOULD No file requires outside of /etc, /bin, /sbin, /usr/bin,
>     /usr/sbin.
>[x]: SHOULD Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: SHOULD Package functions as described.
>[x]: SHOULD Latest version is packaged.
>[x]: SHOULD Package does not include license text files separate from
>     upstream.
>[x]: SHOULD SourceX tarball generation or download is documented.
>     Note: Package contains tarball without URL, check comments
>[x]: SHOULD SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (nicolasff-phpredis-2.2.2-38-g6f7087f.tar.gz)
>
>     Source not prefixed with %{name} but this is because of upstream (Github) 
>     naming.  Also, upstream name ("phpredis") does not match Fedora naming
>     convention ("php-redis" does).
>
>[x]: SHOULD SourceX is a working URL.
>[x]: SHOULD Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: SHOULD Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: SHOULD %check is present and all tests pass.
>[x]: SHOULD Packages should try to preserve timestamps of original installed
>     files.
>[x]: SHOULD Spec use %global instead of %define.
>
>
>==== PHP ====
>[x]: MUST Package requires php-common instead of php.
>
>     Packages requires the following instead:
>     Requires:      php(zend-abi) = %{php_zend_api}
>     Requires:      php(api) = %{php_core_api}
>
>Issues:
>
>
>Rpmlint
>-------
>Checking: php-redis-2.2.2-5.git6f7087f.fc17.x86_64.rpm
>          php-redis-debuginfo-2.2.2-5.git6f7087f.fc17.x86_64.rpm
>          php-redis-2.2.2-5.git6f7087f.fc17.src.rpm
>php-redis.x86_64: W: spelling-error %description -l en_US phpredis -> predispose
>php-redis.src: W: spelling-error %description -l en_US phpredis -> predispose
>php-redis.src: W: invalid-url Source0: nicolasff-phpredis-2.2.2-38-g6f7087f.tar.gz
>3 packages and 0 specfiles checked; 0 errors, 3 warnings.
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-redis-debuginfo
>1 packages and 0 specfiles checked; 0 errors, 0 warnings.
># echo 'rpmlint-done:'
>
>Requires
>--------
>php-redis-2.2.2-5.git6f7087f.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>    libc.so.6()(64bit)  
>    php(api) = 20100412-x86-64
>    php(zend-abi) = 20100525-x86-64
>    php-pecl-igbinary(x86-64)  
>    rtld(GNU_HASH)  
>
>php-redis-debuginfo-2.2.2-5.git6f7087f.fc17.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>
>Provides
>--------
>php-redis-2.2.2-5.git6f7087f.fc17.x86_64.rpm:
>    
>    php-redis = 2.2.2-5.git6f7087f.fc17
>    php-redis(x86-64) = 2.2.2-5.git6f7087f.fc17
>
>php-redis-debuginfo-2.2.2-5.git6f7087f.fc17.x86_64.rpm:
>    
>    php-redis-debuginfo = 2.2.2-5.git6f7087f.fc17
>    php-redis-debuginfo(x86-64) = 2.2.2-5.git6f7087f.fc17
>
>MD5-sum check
>-------------
>930fd647b3c8cad80817e1492f26c454  srpm-unpacked/nicolasff-phpredis-2.2.2-38-g6f7087f.tar.gz
>930fd647b3c8cad80817e1492f26c454  nicolasff-phpredis-2.2.2-38-g6f7087f.tar.gz
>
>
>Generated by fedora-review 0.2.2 (9f8c0e5) last change: 2012-08-09
>Command line :/usr/bin/fedora-review -b 853463
>External plugins:

Actions: View

Attachments on bug 853463: 612642