Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 614202 Details for
Bug 856300
CVE-2012-4433 gegl: Integer overflow, leading to heap-based buffer overflow by parsing PPM image headers
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
quick fix, implements a safemultiply function, not sure if its portable though
gegl-overflow.patch (text/plain), 893 bytes, created by
Huzaifa S. Sidhpurwala
on 2012-09-19 05:23:57 UTC
(
hide
)
Description:
quick fix, implements a safemultiply function, not sure if its portable though
Filename:
MIME Type:
Creator:
Huzaifa S. Sidhpurwala
Created:
2012-09-19 05:23:57 UTC
Size:
893 bytes
patch
obsolete
>--- gegl-0.2.0/operations/external/ppm-load.c 2012-03-30 01:35:50.000000000 +0530 >+++ gegl-0.2.0.fix/operations/external/ppm-load.c 2012-09-19 10:45:30.303452498 +0530 >@@ -51,6 +51,14 @@ > guchar *data; > } pnm_struct; > >+gint mul(gint a, gint b) >+{ >+ if (b && a > ((gint)-1) / b) { >+ return 0; >+ } >+ return a * b; >+} >+ > static gboolean > ppm_load_read_header(FILE *fp, > pnm_struct *img) >@@ -84,7 +92,13 @@ > /* Get Width and Height */ > img->width = strtol (header,&ptr,0); > img->height = atoi (ptr); >- img->numsamples = img->width * img->height * CHANNEL_COUNT; >+ img->numsamples = mul(mul(img->width, img->height), CHANNEL_COUNT); >+ >+ if (img->numsamples == 0) >+ { >+ g_warning("Possible integer overflow"); >+ return FALSE; >+ } > > fgets (header,MAX_CHARS_IN_ROW,fp); > maxval = strtol (header,&ptr,0);
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=614202">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 856300
:
614202
|
614203
|
633906