Attachment 616341 Details for Bug 857282 – improve warning message for remain size checking

[patch] improve warning message for remain size checking

6.4-remain-size-warning.patch (text/plain), 3.74 KB, created by Dave Young on 2012-09-24 03:17:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Dave Young

Created: 2012-09-24 03:17:19 UTC

Size: 3.74 KB

patch

obsolete

>Resolves: bz857282
>
>Currently if available disk size is less than total memsize, we will
>warn user below:
>echo "Warning: There is not enough space to save a vmcore."
>echo "         The size of $DUMP_TARGET should be much greater than
>$memtotal kilo bytes.
>
>This is right for core_collector such as 'cp', But for core_collector such
>as 'makedumpfile' which will compress and exclude useless pages this could
>be not right. We can not guarantee the captured vmcore size is always small
>enough because this depends on the 1st kernel memory usage, so we still
>need a warning message.
>
>Improve the warning as following instead:
>"Warning: There might not be enough space to save a vmcore."
>"         The size of $DUMP_TARGET should be greater than $memtotal kilo bytes."
>
>
>Signed-off-by: Dave Young <dyoung@redhat.com>
>---
> mkdumprd |   16 ++++++++--------
> 1 file changed, 8 insertions(+), 8 deletions(-)
>
>--- kexec-tools.orig/mkdumprd
>+++ kexec-tools/mkdumprd
>@@ -3206,8 +3206,8 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                     #check for available size is greater than $memtotal
>                     available_size=$(fdisk -s $DUMP_TARGET)
>                     if [ $available_size -lt $memtotal ]; then
>-                        echo "Warning: There is not enough space to save a vmcore."
>-                        echo "         The size of $DUMP_TARGET should be much greater than $memtotal kilo bytes."
>+                        echo "Warning: There might not be enough space to save a vmcore."
>+                        echo "         The size of $DUMP_TARGET should be greater than $memtotal kilo bytes."
>                     fi
> 
>                     #setup raw case
>@@ -3303,8 +3303,8 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
> 
>                         #check for available size is greater than $memtotal
>                         if [ $available_size -lt $memtotal ]; then
>-                            echo "Warning: There is not enough space to save a vmcore."
>-                            echo "         The size of $DUMP_TARGET should be much greater than $memtotal kilo bytes."
>+                            echo "Warning: There might not be enough space to save a vmcore."
>+                            echo "         The size of $DUMP_TARGET should be greater than $memtotal kilo bytes."
>                         fi
>     
>                         #setup nfs case
>@@ -3387,8 +3387,8 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
> 
>                         #check for available size is greater than $memtotal
>                         if [ $available_size -lt $memtotal ]; then
>-                            echo "Warning: There is not enough space to save a vmcore."
>-                            echo "         The size of $rlocation:$tdir should be much greater than $memtotal kilo bytes."
>+                            echo "Warning: There might not be enough space to save a vmcore."
>+                            echo "         The size of $rlocation:$tdir should be greater than $memtotal kilo bytes."
>                         fi
>                         #We do this to remove the temp directory from above
>                         ssh -q $s_opts $rlocation rmdir $tdir
>@@ -3468,8 +3468,8 @@ if [ -n "$KDUMP_CONFIG_FILE" ]; then
>                     fi
>                     #check for available size is greater than $memtotal
>                     if [ $available_size -lt $memtotal ]; then
>-                        echo "Warning: There is not enough space to save a vmcore."
>-                        echo "         The size of $DUMP_TARGET should be much greater than $memtotal kilo bytes."
>+                        echo "Warning: There might not be enough space to save a vmcore."
>+                        echo "         The size of $DUMP_TARGET should be greater than $memtotal kilo bytes."
>                     fi
> 
>

Actions: View | Diff

Attachments on bug 857282: 616341