Attachment 616975 Details for Bug 860238 – Fixes the problem

[patch] Fixes the problem

qemu-1.2.0-qxl-ioport-check.patch (text/plain), 1.20 KB, created by Alexander Larsson on 2012-09-25 11:26:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Larsson

Created: 2012-09-25 11:26:20 UTC

Size: 1.20 KB

patch

obsolete

>From 7d18f34a2b6febbea6d665836adaaf237cb8aab7 Mon Sep 17 00:00:00 2001
>From: Alexander Larsson <alexl@redhat.com>
>Date: Tue, 25 Sep 2012 11:07:52 +0200
>Subject: [PATCH] qxl: Fix regression in ioport version checking
>
>The commit 020af1c45fec664d5d4cf3b8e5117f8bc1d691f2 introduced
>a new qxl version (v4) with a new QXL_IO_MONITORS_CONFIG_ASYNC operation.
>However, the version check that only allows v4 devices to call it
>is wrong, as checks for io_port >= QXL_IO_FLUSH_SURFACES_ASYNC.
>Both QXL_IO_FLUSH_SURFACES_ASYNC and QXL_IO_FLUSH_RELEASE are
>valid v3 calls as per:
>http://cgit.freedesktop.org/spice/spice-protocol/tree/spice/qxl_dev.h
>
>The right comparison is io_port > QXL_IO_FLUSH_RELEASE.
>---
> hw/qxl.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/hw/qxl.c b/hw/qxl.c
>index 33169f3..73e9129 100644
>--- a/hw/qxl.c
>+++ b/hw/qxl.c
>@@ -1466,7 +1466,7 @@ static void ioport_write(void *opaque, target_phys_addr_t addr,
>     }
> 
>     if (d->revision <= QXL_REVISION_STABLE_V10 &&
>-        io_port >= QXL_IO_FLUSH_SURFACES_ASYNC) {
>+        io_port > QXL_IO_FLUSH_RELEASE) {
>         qxl_set_guest_bug(d, "unsupported io %d for revision %d\n",
>             io_port, d->revision);
>         return;
>-- 
>1.7.12
>

Actions: View | Diff

Attachments on bug 860238: 616975