Attachment 617999 Details for Bug 860711 – Proposed patch

[patch] Proposed patch

2012-09-27-0001-Don-t-access-invalid-mem-in-totemconfig-interfaces.patch (text/plain), 1.25 KB, created by Jan Friesse on 2012-09-27 11:01:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Friesse

Created: 2012-09-27 11:01:14 UTC

Size: 1.25 KB

patch

obsolete

>From 70295f1fca865335dbf0c2874c7c7c7072af4d28 Mon Sep 17 00:00:00 2001
>From: Jan Friesse <jfriesse@redhat.com>
>Date: Thu, 27 Sep 2012 12:45:54 +0200
>Subject: [PATCH] Don't access invalid mem in totemconfig interfaces
>
>When ringnumber in config file was set to value bigger or equal to
>INTERFACE_MAX, we are using this big value as index to totemconfig
>interfaces array, resulting to access to invalid memory and segfault.
>
>Instead of that, ringnumber is now checked and proper error message is
>printed if value is too big.
>
>Signed-off-by: Jan Friesse <jfriesse@redhat.com>
>---
> exec/totemconfig.c |   10 ++++++++++
> 1 files changed, 10 insertions(+), 0 deletions(-)
>
>diff --git a/exec/totemconfig.c b/exec/totemconfig.c
>index a35ec56..e1b9f80 100644
>--- a/exec/totemconfig.c
>+++ b/exec/totemconfig.c
>@@ -495,6 +495,16 @@ extern int totem_config_read (
> 		member_count = 0;
> 
> 		ringnumber = atoi(ringnumber_key);
>+
>+		if (ringnumber >= INTERFACE_MAX) {
>+			snprintf (error_string_response, sizeof(error_string_response),
>+			    "parse error in config: interface ring number %u is bigger then allowed maximum %u\n",
>+			    ringnumber, INTERFACE_MAX - 1);
>+
>+			*error_string = error_string_response;
>+			return -1;
>+		}
>+
> 		/*
> 		 * Get the bind net address
> 		 */
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 860711: 617571 | 617999