Attachment 619445 Details for Bug 676841 – [PATCH] command-not-found: Make sure we return 127 if we fail

[patch] [PATCH] command-not-found: Make sure we return 127 if we fail

0002-command-not-found-Make-sure-we-return-127-if-we-fail.patch (text/plain), 1.20 KB, created by Elad Alfassa on 2012-09-30 14:50:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Elad Alfassa

Created: 2012-09-30 14:50:48 UTC

Size: 1.20 KB

patch

obsolete

>From 95b54f346d1c0a4a04593eebb0ef36d6278bbc56 Mon Sep 17 00:00:00 2001
>From: Elad Alfassa <elad@fedoraproject.org>
>Date: Sun, 30 Sep 2012 16:46:22 +0200
>Subject: [PATCH 2/2] command-not-found: Make sure we return 127 if we fail
>
>This commit is very simple. I changed the default return value
>to EXIT_COMMAND_NOT_FOUND (which is 127). It makes no sense defaulting to 0
>because if we return the original value of retval we have probably failed.
>
>If we do succeed in installing the package that provides the command, we then
>spawn the command and return its return value.
>
>This fixes RHBZ #676841
>---
> contrib/command-not-found/pk-command-not-found.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/contrib/command-not-found/pk-command-not-found.c b/contrib/command-not-found/pk-command-not-found.c
>index f6b1ee9..dba6353 100644
>--- a/contrib/command-not-found/pk-command-not-found.c
>+++ b/contrib/command-not-found/pk-command-not-found.c
>@@ -758,7 +758,7 @@ main (int argc, char *argv[])
> 	gchar *text;
> 	const gchar *possible;
> 	gchar **parts;
>-	guint retval = EXIT_SUCCESS;
>+	guint retval = EXIT_COMMAND_NOT_FOUND;
> 
> 	setlocale (LC_ALL, "");
> 	bindtextdomain (GETTEXT_PACKAGE, PACKAGE_LOCALE_DIR);
>-- 
>1.7.12.1
>

Actions: View | Diff

Attachments on bug 676841: 619445