Attachment 620096 Details for Bug 859879 – Patch for ibusimcontext.c

[patch] Patch for ibusimcontext.c

ibus-859879-segv-im-ibus.patch (text/plain), 1.21 KB, created by fujiwara on 2012-10-02 02:56:56 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: fujiwara

Created: 2012-10-02 02:56:56 UTC

Size: 1.21 KB

patch

obsolete

>--- ibus-1.4.99.20120822/client/gtk3/ibusimcontext.c.orig	2012-09-26 05:41:16.936729871 +0900
>+++ ibus-1.4.99.20120822/client/gtk3/ibusimcontext.c	2012-10-02 02:46:01.800571544 +0900
>@@ -372,10 +372,17 @@ _key_snooper_cb (GtkWidget   *widget,
> 
>     } while (0);
> 
>     if (ibusimcontext != NULL) {
>+        /* "retrieve-surrounding" signal sometimes calls unref by
>+         * gtk_im_multicontext_get_slave() because priv->context_id is not
>+         * the latest than global_context_id in GtkIMMulticontext.
>+         * Since _focus_im_context is gotten by the focus_in event,
>+         * it would be good to call ref here.
>+         */
>+        g_object_ref (ibusimcontext);
>         _request_surrounding_text (ibusimcontext);
>         ibusimcontext->time = event->time;
>     }
> 
>     guint state = event->state;
>     if (event->type == GDK_KEY_RELEASE) {
>@@ -410,6 +426,13 @@ _key_snooper_cb (GtkWidget   *widget,
>         event->state |= IBUS_IGNORED_MASK;
>     }
> 
>+    if (ibusimcontext != NULL) {
>+        /* unref ibusimcontext could call ibus_im_context_finalize here
>+         * because "retrieve-surrounding" signal could call unref.
>+         */
>+        g_object_unref (ibusimcontext);
>+    }
>+
>     return retval;
> }
>

Actions: View | Diff

Attachments on bug 859879: 617482 | 618516 | 619736 | 620096