Attachment 625132 Details for Bug 728365 – upstream committed patch for 728365

[patch] upstream committed patch for 728365

bz728365-warn-dont-fail-on-old-initrd.patch (text/plain), 1.88 KB, created by Jonathan Earl Brassow on 2012-10-10 20:10:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Earl Brassow

Created: 2012-10-10 20:10:14 UTC

Size: 1.88 KB

patch

obsolete

>commit 33b5abfb99e0de71fea3d7a39901dea576129458
>Author: Jonathan Brassow <jbrassow@redhat.com>
>Date:   Fri Oct 5 14:07:06 2012 -0500
>
>    LVM Agents:  Warn instead of fail if initrd is newer than lvm.conf
>    
>    There are many reasons why a user may change the lvm.conf file.  They might
>    change filters or default segment types, etc.  Making the HA LVM scripts
>    error our every time the lvm.conf file is newer than the initrd, can cause
>    serious problems.  For example, if a service is running and lvm.conf is
>    changed, a subsequent fail-over would not work because the HA LVM script
>    would abort on this condition.
>    
>    Instead of making things potentially worse, we have the scripts warn the
>    user (rather than failing) whenever this condition is hit.  That way,
>    the user isn't suddenly surprised by things not working.
>    
>    Signed-off-by: Jonathan Brassow <jbrassow@redhat.com>
>
>diff --git a/rgmanager/src/resources/lvm.sh b/rgmanager/src/resources/lvm.sh
>index f18321f..d1a4013 100644
>--- a/rgmanager/src/resources/lvm.sh
>+++ b/rgmanager/src/resources/lvm.sh
>@@ -107,7 +107,12 @@ function ha_lvm_proper_setup_check
> 	if [ "$(find /boot -name *.img -newer /etc/lvm/lvm.conf)" == "" ]; then
> 		ocf_log err "HA LVM:  Improper setup detected"
> 		ocf_log err "* initrd image needs to be newer than lvm.conf"
>-		return $OCF_ERR_GENERIC
>+
>+		# While dangerous if not done the first time, there are many
>+		# cases where we don't simply want to fail here.  Instead,
>+		# keep warning until the user remakes the initrd - or has
>+		# it done for them by upgrading the kernel.
>+		#return $OCF_ERR_GENERIC
> 	fi
> 
> 	return $OCF_SUCCESS
>@@ -139,9 +144,7 @@ status|monitor)
> 	;;
> 		    
> stop)
>-	if ! ha_lvm_proper_setup_check; then
>-		ocf_log err "WARNING: An improper setup can cause data corruption!"
>-	fi
>+	ha_lvm_proper_setup_check
> 
> 	if [ -z $OCF_RESKEY_lv_name ]; then
> 		vg_stop || exit 1

Actions: View | Diff

Attachments on bug 728365: 580844 | 625132