Attachment 627155 Details for Bug 866271 – Patch - autofs4 - fix reset pending flag on mount fail

[patch] Patch - autofs4 - fix reset pending flag on mount fail

autofs4-fix-reset-pending-flag-on-mount-fail.patch (text/plain), 1.22 KB, created by Ian Kent on 2012-10-15 01:05:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Ian Kent

Created: 2012-10-15 01:05:05 UTC

Size: 1.22 KB

patch

obsolete

>autofs4 - fix reset pending flag on mount fail
>
>From: Ian Kent <raven@themaw.net>
>
>Bugzilla bug: https://bugzilla.redhat.com/show_bug.cgi?id=866271
>
>Upstream commit: 49999ab27eab6289a8e4f450e148bdab521361b2
>
>In autofs4_d_automount(), if a mount fail occurs the AUTOFS_INF_PENDING
>mount pending flag is not cleared.
>
>One effect of this is when using the "browse" option, directory entry
>attributes show up with all "?"s due to the incorrect callback and
>subsequent failure return (when in fact no callback should be made).
>
>Signed-off-by: Ian Kent <ikent@redhat.com>
>Cc: stable@vger.kernel.org
>---
>
> fs/autofs4/root.c |    6 ++++--
> 1 files changed, 4 insertions(+), 2 deletions(-)
>
>
>diff --git a/fs/autofs4/root.c b/fs/autofs4/root.c
>index 97bc1da..3efff41 100644
>--- a/fs/autofs4/root.c
>+++ b/fs/autofs4/root.c
>@@ -383,10 +383,12 @@ static struct vfsmount *autofs4_d_automount(struct path *path)
> 		ino->flags |= AUTOFS_INF_PENDING;
> 		spin_unlock(&sbi->fs_lock);
> 		status = autofs4_mount_wait(dentry);
>-		if (status)
>-			return ERR_PTR(status);
> 		spin_lock(&sbi->fs_lock);
> 		ino->flags &= ~AUTOFS_INF_PENDING;
>+		if (status) {
>+			spin_unlock(&sbi->fs_lock);
>+			return ERR_PTR(status);
>+		}
> 	}
> done:
> 	if (!(ino->flags & AUTOFS_INF_EXPIRING)) {

Actions: View | Diff

Attachments on bug 866271: 627155