Attachment 628620 Details for Bug 867153 – proposed patch

[patch] proposed patch

mod_auth_kerb-5.4-localname.patch (text/plain), 980 bytes, created by Jan Kaluža on 2012-10-17 09:17:53 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jan Kaluža

Created: 2012-10-17 09:17:53 UTC

Size: 980 bytes

patch

obsolete

>diff --git a/src/mod_auth_kerb.c b/src/mod_auth_kerb.c
>index c3356b3..bba0809 100644
>--- a/src/mod_auth_kerb.c
>+++ b/src/mod_auth_kerb.c
>@@ -80,6 +80,7 @@
> 
> #define MECH_NEGOTIATE "Negotiate"
> #define SERVICE_NAME "HTTP"
>+#define MAX_LOCAL_USERNAME 255
> 
> #include <httpd.h>
> #include <http_config.h>
>@@ -1830,13 +1831,13 @@ do_krb5_an_to_ln(request_rec *r) {
> 		    krb5_get_err_text(kcontext, code));
> 	   goto end;
>   }
>-  MK_USER_LNAME = apr_pcalloc(r->pool, strlen(MK_USER)+1);
>+  MK_USER_LNAME = apr_pcalloc(r->pool, MAX_LOCAL_USERNAME);
>   if (MK_USER_LNAME == NULL) {
>      log_rerror(APLOG_MARK, APLOG_ERR, 0, r,
> 	   	"ap_pcalloc() failed (not enough memory)");
>      goto end;
>   }
>-    code = krb5_aname_to_localname(kcontext, client, strlen(MK_USER), MK_USER_LNAME);
>+    code = krb5_aname_to_localname(kcontext, client, sizeof(MK_USER_LNAME), MK_USER_LNAME);
>     if (code) {
> 		  if (code != KRB5_LNAME_NOTRANS) {
>       			log_rerror(APLOG_MARK, APLOG_ERR, 0, r,

Actions: View | Diff

Attachments on bug 867153: 628620 | 628639