Attachment 629093 Details for Bug 862862 – [1/2] ixgbevf: Prevent RX/TX statistics getting reset to zero

[patch] [1/2] ixgbevf: Prevent RX/TX statistics getting reset to zero

0001-ixgbevf-Prevent-RX-TX-statistics-getting-reset-to-ze.patch (text/plain), 2.62 KB, created by Laszlo Ersek on 2012-10-17 21:36:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Laszlo Ersek

Created: 2012-10-17 21:36:34 UTC

Size: 2.62 KB

patch

obsolete

>From 5653d6fe5233a74791be1f12b98111d1ff4e0096 Mon Sep 17 00:00:00 2001
>From: Narendra K <narendra_k@dell.com>
>Date: Mon, 16 Jul 2012 15:24:41 +0000
>Subject: [PATCH 1/2] ixgbevf: Prevent RX/TX statistics getting reset to zero
>
>Dependency backport of upstream Linux commit 93659763. We don't have
>4197aa7b mentioned below, but it is irrelevant (ie. not a dependency) for
>either our purposes or in fact for commit 93659763 itself.
>
>  commit 936597631dd310e220544dc5c6075d924efd39b2
>  Author: Narendra K <narendra_k@dell.com>
>  Date:   Mon Jul 16 15:24:41 2012 +0000
>
>      ixgbevf: Prevent RX/TX statistics getting reset to zero
>
>      The commit 4197aa7bb81877ebb06e4f2cc1b5fea2da23a7bd implements 64
>      bit per ring statistics. But the driver resets the 'total_bytes' and
>      'total_packets' from RX and TX rings in the RX and TX interrupt
>      handlers to zero. This results in statistics being lost and user
>      space reporting RX and TX statistics as zero. This patch addresses
>      the issue by preventing the resetting of RX and TX ring statistics
>      to zero.
>
>      Signed-off-by: Narendra K <narendra_k@dell.com>
>      Tested-by: Sibai Li <sibai.li@intel.com>
>      Signed-off-by: Jeff Kirsher <jeffrey.t.kirsher@intel.com>
>      Signed-off-by: David S. Miller <davem@davemloft.net>
>Signed-off-by: Laszlo Ersek <lersek@redhat.com>
>---
> drivers/net/ixgbevf/ixgbevf_main.c |   12 ------------
> 1 files changed, 0 insertions(+), 12 deletions(-)
>
>diff --git a/drivers/net/ixgbevf/ixgbevf_main.c b/drivers/net/ixgbevf/ixgbevf_main.c
>index ed54489..0548659 100644
>--- a/drivers/net/ixgbevf/ixgbevf_main.c
>+++ b/drivers/net/ixgbevf/ixgbevf_main.c
>@@ -973,8 +973,6 @@ static irqreturn_t ixgbevf_msix_clean_tx(int irq, void *data, struct pt_regs *re
> 	r_idx = find_first_bit(q_vector->txr_idx, adapter->num_tx_queues);
> 	for (i = 0; i < q_vector->txr_count; i++) {
> 		tx_ring = &(adapter->tx_ring[r_idx]);
>-		tx_ring->total_bytes = 0;
>-		tx_ring->total_packets = 0;
> 		ixgbevf_clean_tx_irq(adapter, tx_ring);
> 		r_idx = find_next_bit(q_vector->txr_idx, adapter->num_tx_queues,
> 				      r_idx + 1);
>@@ -998,16 +996,6 @@ static irqreturn_t ixgbevf_msix_clean_rx(int irq, void *data, struct pt_regs *re
> 	struct ixgbe_hw *hw = &adapter->hw;
> 	struct ixgbevf_ring  *rx_ring;
> 	int r_idx;
>-	int i;
>-
>-	r_idx = find_first_bit(q_vector->rxr_idx, adapter->num_rx_queues);
>-	for (i = 0; i < q_vector->rxr_count; i++) {
>-		rx_ring = &(adapter->rx_ring[r_idx]);
>-		rx_ring->total_bytes = 0;
>-		rx_ring->total_packets = 0;
>-		r_idx = find_next_bit(q_vector->rxr_idx, adapter->num_rx_queues,
>-				      r_idx + 1);
>-	}
> 
> 	if (!q_vector->rxr_count)
> 		return IRQ_HANDLED;
>-- 
>1.7.1
>

Actions: View | Diff

Attachments on bug 862862: 624960 | 629093 | 653948 | 653952 | 663166 | 663204 | 663206 | 672173 | 672220 | 674634 | 674635 | 674871 | 674973 | 675360 | 675802