Attachment 629784 Details for Bug 867914 – Resolve possible arch-related issue in pmcollect interrupt handling

[patch] Resolve possible arch-related issue in pmcollect interrupt handling

pmcollectl.patch (text/plain), 2.59 KB, created by Nathan Scott on 2012-10-19 06:02:01 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nathan Scott

Created: 2012-10-19 06:02:01 UTC

Size: 2.59 KB

patch

obsolete

>diff --git a/src/pmcollectl/pmcollectl.py b/src/pmcollectl/pmcollectl.py
>index c7c5a4d..8bb4ac3 100755
>--- a/src/pmcollectl/pmcollectl.py
>+++ b/src/pmcollectl/pmcollectl.py
>@@ -499,9 +499,9 @@ class _interrupt(_subsys):
>     def get_stats(self):
>         get_stats (self.interrupt_metrics, self.int_metric_name, self.int_metric_desc, self.interrupt_metric_value, self.old_interrupt_metric_value)
> 
>-    def get_interrupt_metric_value(self, idx):
>+    def get_interrupt_metric_value_len(self, idx):
>         if idx in self.interrupt_metrics:
>-            return self.interrupt_metric_value[self.interrupt_metrics_dict[idx]]
>+            return len(self.interrupt_metric_value[self.interrupt_metrics_dict[idx]])
>         else:
>             return 0
> 
>@@ -519,17 +519,17 @@ class _interrupt(_subsys):
>     def print_brief(self):
>         int_count = []
>         _=self.interrupt_metrics_dict
>-        for k in range(len(self.get_interrupt_metric_value('kernel.percpu.interrupts.MCP'))):
>+        for k in range(self.get_interrupt_metric_value_len('kernel.percpu.interrupts.MCP')):
>             int_count.append(0)
>             for j  in range(_['kernel.percpu.interrupts.MCP'], len(self.interrupt_metric_value)):
>                 int_count[k] += self.interrupt_metric_value[j][k]
>                 
>-        for k in range(len(self.get_interrupt_metric_value('kernel.percpu.interrupts.MCP'))):
>+        for k in range(self.get_interrupt_metric_value_len('kernel.percpu.interrupts.MCP')):
>             print "%4d " % (int_count[k]),
>     def print_detail(self):
>         _=self.interrupt_metrics_dict
>         for j  in range(_['kernel.percpu.interrupts.MCP'], len(self.interrupt_metrics_dict)):
>-            for k in range(len(self.get_interrupt_metric_value('kernel.percpu.interrupts.MCP'))):
>+            for k in range(self.get_interrupt_metric_value_len('kernel.percpu.interrupts.MCP')):
>                 have_nonzero_value = False
>                 if self.interrupt_metric_value[j][k] != 0:
>                     have_nonzero_value = True
>@@ -537,7 +537,7 @@ class _interrupt(_subsys):
>                     continue
>                 # pcp does not give the interrupt # so print spaces
>                 print "        ",
>-                for k in range(len(self.get_interrupt_metric_value('kernel.percpu.interrupts.MCP'))):
>+                for k in range(self.get_interrupt_metric_value_len('kernel.percpu.interrupts.MCP')):
>                     print "%4d " % (self.interrupt_metric_value[j][k]),
>                 text = (pm.pmLookupText(self.int_metric_name[j], pmapi.PM_TEXT_ONELINE))
>                 print "%-18s %s" % (text[:(str.index(text," "))],

Actions: View | Diff

Attachments on bug 867914: 629784 | 629874 | 629876 | 629898