Attachment 633940 Details for Bug 870485 – patch against fuse fedpkg repo to add upstream patch

[patch] patch against fuse fedpkg repo to add upstream patch

0001-Patch-for-free-at-wrong-pointer-level-in-try_get_pat.patch (text/plain), 2.53 KB, created by Tyson Whitehead on 2012-10-26 15:40:32 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tyson Whitehead

Created: 2012-10-26 15:40:32 UTC

Size: 2.53 KB

patch

obsolete

>From 426f4842ac8740ec318affc94c6cc97e4954e9ab Mon Sep 17 00:00:00 2001
>From: Tyson Whitehead <twhitehead@gmail.com>
>Date: Tue, 25 Sep 2012 23:20:44 -0400
>Subject: [PATCH] Patch for free at wrong pointer level in try_get_path2 from
> upstream
>
>---
> ...x-crash-caused-by-freeing-a-stack-address.patch | 33 ++++++++++++++++++++++
> fuse.spec                                          |  2 ++
> 2 files changed, 35 insertions(+)
> create mode 100644 fuse-0001-Fix-crash-caused-by-freeing-a-stack-address.patch
>
>diff --git a/fuse-0001-Fix-crash-caused-by-freeing-a-stack-address.patch b/fuse-0001-Fix-crash-caused-by-freeing-a-stack-address.patch
>new file mode 100644
>index 0000000..d895c69
>--- /dev/null
>+++ b/fuse-0001-Fix-crash-caused-by-freeing-a-stack-address.patch
>@@ -0,0 +1,33 @@
>+From 17aef5d7802b241b032367672c5f6d60ceb9a28b Mon Sep 17 00:00:00 2001
>+From: Miklos Szeredi <mszeredi@suse.cz>
>+Date: Thu, 19 Jul 2012 15:05:56 +0200
>+Subject: [PATCH] Fix crash caused by freeing a stack address
>+
>+The failure path of try_get_path2() erronously tried to free the "path1" value
>+(an address on the stack) instead of the allocated string pointed to by "path1".
>+This caused the library to crash.
>+
>+Reported by Itay Perl
>+
>+Conflicts:
>+	ChangeLog
>+---
>+ lib/fuse.c | 2 +-
>+ 1 file changed, 1 insertion(+), 1 deletion(-)
>+
>+diff --git a/lib/fuse.c b/lib/fuse.c
>+index d511964..c26d82d 100644
>+--- a/lib/fuse.c
>++++ b/lib/fuse.c
>+@@ -740,7 +740,7 @@ static int try_get_path2(struct fuse *f, fuse_ino_t nodeid1, const char *name1,
>+ 			struct node *wn1 = wnode1 ? *wnode1 : NULL;
>+ 
>+ 			unlock_path(f, nodeid1, wn1, NULL, ticket);
>+-			free(path1);
>++			free(*path1);
>+ 			if (ticket && err != -EAGAIN)
>+ 				release_tickets(f, nodeid1, wn1, ticket);
>+ 		}
>+-- 
>+1.7.11.4
>+
>diff --git a/fuse.spec b/fuse.spec
>index 9955c04..e75c54c 100644
>--- a/fuse.spec
>+++ b/fuse.spec
>@@ -10,6 +10,7 @@ Source0:        http://downloads.sourceforge.net/%{name}/%{name}-%{version}.tar.
> Source1:	%{name}.conf
> 
> Patch1:		fuse-0001-More-parentheses.patch
>+Patch2:         fuse-0001-Fix-crash-caused-by-freeing-a-stack-address.patch
> BuildRoot:      %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> Requires:       kernel >= 2.6.14
> Requires:       which
>@@ -54,6 +55,7 @@ pgk-config) to develop FUSE based applications/filesystems.
> #disable device creation during build/install
> sed -i 's|mknod|echo Disabled: mknod |g' util/Makefile.in
> %patch1 -p1 -b .add_parentheses
>+%patch2 -p1 -b .stack_free_crash
> 
> %build
> # Can't pass --disable-static here, or else the utils don't build
>-- 
>1.7.11.7
>

Actions: View | Diff

Attachments on bug 870485: 633940