Attachment 634849 Details for Bug 870864 – Patch 2 - extended key usage support in nss-util

[patch] Patch 2 - extended key usage support in nss-util

0001-nssutil-Add-extended-key-usage-for-MS-Authenticode-Code-Sign.patch (text/plain), 1.87 KB, created by Elio Maldonado Batiz on 2012-10-29 03:30:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Elio Maldonado Batiz

Created: 2012-10-29 03:30:30 UTC

Size: 1.87 KB

patch

obsolete

>Index: mozilla/security/nss/lib/util/secoid.c
>===================================================================
>RCS file: /cvsroot/mozilla/security/nss/lib/util/secoid.c,v
>retrieving revision 1.67
>diff -u -p -r1.67 secoid.c
>--- mozilla/security/nss/lib/util/secoid.c	27 Sep 2012 17:23:33 -0000	1.67
>+++ mozilla/security/nss/lib/util/secoid.c	29 Oct 2012 00:47:01 -0000
>@@ -145,6 +145,13 @@ const char __nss_util_sccsid[] = "@(#)NS
> #define MICROSOFT_OID 0x2b, 0x6, 0x1, 0x4, 0x1, 0x82, 0x37
> #define EV_NAME_ATTRIBUTE 	MICROSOFT_OID, 60, 2, 1
> 
>+/* Microsoft Crypto 2.0 ID space */
>+/* { 1.3.6.1.4.1.311.10 } */
>+#define MS_CRYPTO_20            MICROSOFT_OID, 10
>+/* Microsoft Crypto 2.0 Extended Key Usage ID space */
>+/* { 1.3.6.1.4.1.311.10.3 } */
>+#define MS_CRYPTO_EKU           MS_CRYPTO_20, 3
>+
> #define CERTICOM_OID            0x2b, 0x81, 0x04
> #define SECG_OID                CERTICOM_OID, 0x00
> 
>@@ -448,6 +455,8 @@ CONST_OID pkixExtendedKeyUsageCodeSign[]
> CONST_OID pkixExtendedKeyUsageEMailProtect[]  	= { PKIX_KEY_USAGE, 4 };
> CONST_OID pkixExtendedKeyUsageTimeStamp[]     	= { PKIX_KEY_USAGE, 8 };
> CONST_OID pkixOCSPResponderExtendedKeyUsage[] 	= { PKIX_KEY_USAGE, 9 };
>+/* QUESTION: why 1 instead of 10? */
>+CONST_OID msExtendedKeyUsageCodeSigning[]       = { MS_CRYPTO_EKU, 1 };
> 
> /* OIDs for Netscape defined algorithms */
> CONST_OID netscapeSMimeKEA[] 			= { NETSCAPE_ALGS, 0x01 };
>@@ -1630,6 +1639,11 @@ const static SECOidData oids[SEC_OID_TOT
> 	SEC_OID_NIST_DSA_SIGNATURE_WITH_SHA224_DIGEST,
> 	"DSA with SHA-224 Signature",
> 	CKM_INVALID_MECHANISM /* not yet defined */, INVALID_CERT_EXTENSION),
>+
>+    OD( msExtendedKeyUsageCodeSigning, szOID_KP_CTL_USAGE_SIGNING,
>+        "Microsoft Authenticode Code Signing",
>+	CKM_INVALID_MECHANISM, INVALID_CERT_EXTENSION ),
>+
>     OD( nistDSASignaturewithSHA256Digest,
> 	SEC_OID_NIST_DSA_SIGNATURE_WITH_SHA256_DIGEST,
> 	"DSA with SHA-256 Signature",

Flags:

rrelyea: review-

Actions: View | Diff

Attachments on bug 870864: 634838 | 634839 | 634848 | 634849 | 634850 | 636948 | 636949 | 636950 | 641077 | 644478