Attachment 636710 Details for Bug 869119 – review

review

file_869119.txt (text/plain), 5.44 KB, created by Gregor Tätzner on 2012-11-01 15:06:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Gregor Tätzner

Created: 2012-11-01 15:06:51 UTC

Size: 5.44 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[x]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[x]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: Large documentation files are in a -doc subpackage, if required.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/greg/869119-php-sabredav-
>     Sabre_VObject/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[x]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[x]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>
>
>Rpmlint
>-------
>Checking: php-sabredav-Sabre_VObject-1.3.5-2.fc17.noarch.rpm
>          php-sabredav-Sabre_VObject-1.3.5-2.fc17.src.rpm
>php-sabredav-Sabre_VObject.noarch: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily
>php-sabredav-Sabre_VObject.noarch: W: spelling-error Summary(en_US) vCard -> v Card, card
>php-sabredav-Sabre_VObject.src: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily
>php-sabredav-Sabre_VObject.src: W: spelling-error Summary(en_US) vCard -> v Card, card
>2 packages and 0 specfiles checked; 0 errors, 4 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-sabredav-Sabre_VObject
>php-sabredav-Sabre_VObject.noarch: W: spelling-error Summary(en_US) iCalendar -> i Calendar, calendar, legendarily
>php-sabredav-Sabre_VObject.noarch: W: spelling-error Summary(en_US) vCard -> v Card, card
>1 packages and 0 specfiles checked; 0 errors, 2 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-sabredav-Sabre_VObject-1.3.5-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>
>    /bin/sh
>    /usr/bin/pear
>    php-channel(pear.sabredav.org)
>    php-common >= 5
>    php-mbstring
>    php-pear(PEAR)
>    php-pear(pear.sabredav.org/Sabre)
>
>
>
>Provides
>--------
>php-sabredav-Sabre_VObject-1.3.5-2.fc17.noarch.rpm:
>
>    php-pear(Sabre_VObject) = 1.3.5
>    php-pear(pear.sabredav.org/Sabre_VObject) = 1.3.5
>    php-sabredav-Sabre_VObject = 1.3.5-2.fc17
>
>
>
>MD5-sum check
>-------------
>http://pear.sabredav.org/get/Sabre_VObject-1.3.5.tgz :
>  CHECKSUM(SHA256) this package     : 66f9582ed2d42082b1653bd7465eb8f5a1b5c33673ca28b05fd5d1e5408f422e
>  CHECKSUM(SHA256) upstream package : 66f9582ed2d42082b1653bd7465eb8f5a1b5c33673ca28b05fd5d1e5408f422e
>
>
>Generated by fedora-review 0.3.0 (c78e275) last change: 2012-09-24
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 869119

Actions: View

Attachments on bug 869119: 636710