Attachment 637199 Details for Bug 870749 – Work-around patch for qtwebkit.

[patch] Work-around patch for qtwebkit.

qtwebkit-2.2.2-svg-crash-870749.patch (text/plain), 1.71 KB, created by Alexander Gavrilov on 2012-11-02 18:30:42 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alexander Gavrilov

Created: 2012-11-02 18:30:42 UTC

Size: 1.71 KB

patch

obsolete

>From d6ba4794787c0ab64400c08da670f60f0c635fe9 Mon Sep 17 00:00:00 2001
>From: Alexander Gavrilov <angavrilov@gmail.com>
>Date: Wed, 31 Oct 2012 23:37:30 +0400
>Subject: [PATCH] Hook into addChild to catch simple race conditions on
> Node::attach()
>
>---
> Source/WebCore/rendering/svg/RenderSVGText.cpp |    7 +++++++
> Source/WebCore/rendering/svg/RenderSVGText.h   |    2 ++
> 2 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/Source/WebCore/rendering/svg/RenderSVGText.cpp b/Source/WebCore/rendering/svg/RenderSVGText.cpp
>index 1b8cbe3..f0f7689 100644
>--- a/Source/WebCore/rendering/svg/RenderSVGText.cpp
>+++ b/Source/WebCore/rendering/svg/RenderSVGText.cpp
>@@ -62,6 +62,13 @@ bool RenderSVGText::isChildAllowed(RenderObject* child, RenderStyle*) const
>     return child->isInline();
> }
> 
>+void RenderSVGText::addChild(RenderObject* newChild, RenderObject* beforeChild)
>+{
>+    RenderSVGBlock::addChild(newChild, beforeChild);
>+
>+    m_needsPositioningValuesUpdate = true;
>+}
>+
> RenderSVGText* RenderSVGText::locateRenderSVGTextAncestor(RenderObject* start)
> {
>     ASSERT(start);
>diff --git a/Source/WebCore/rendering/svg/RenderSVGText.h b/Source/WebCore/rendering/svg/RenderSVGText.h
>index 15ace2b..e5a3133 100644
>--- a/Source/WebCore/rendering/svg/RenderSVGText.h
>+++ b/Source/WebCore/rendering/svg/RenderSVGText.h
>@@ -38,6 +38,8 @@ public:
> 
>     virtual bool isChildAllowed(RenderObject*, RenderStyle*) const;
> 
>+    virtual void addChild(RenderObject* newChild, RenderObject* beforeChild = 0);
>+
>     void setNeedsPositioningValuesUpdate() { m_needsPositioningValuesUpdate = true; }
>     virtual void setNeedsTransformUpdate() { m_needsTransformUpdate = true; }
>     virtual FloatRect repaintRectInLocalCoordinates() const;
>-- 
>1.7.7.6
>

Actions: View | Diff

Attachments on bug 870749: 634512 | 634513 | 634514 | 634515 | 637199