Attachment 641626 Details for Bug 873447 – Proposed patch

[patch] Proposed patch

0001-DRAFT-remove-writing-ec2rc.patch (text/plain), 1.70 KB, created by Alan Pevec on 2012-11-09 15:28:59 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Alan Pevec

Created: 2012-11-09 15:28:59 UTC

Size: 1.70 KB

patch

obsolete

>From e3f68774e5316a6de100a81230803341766fb454 Mon Sep 17 00:00:00 2001
>From: Alan Pevec <apevec@redhat.com>
>Date: Fri, 9 Nov 2012 16:22:45 +0100
>Subject: [PATCH] DRAFT remove writing ec2rc
>
>avoid potential insecure file storage of credentials
>
>CVE-2011(?)-4965
>
>http://bugzilla.redhat.com/show_bug.cgi?id=873447
>
>Change-Id: I104b1a1e056696aa67873d7f63d8bfe180cd298c
>---
> tools/sample_data.sh |   20 --------------------
> 1 files changed, 0 insertions(+), 20 deletions(-)
>
>diff --git a/tools/sample_data.sh b/tools/sample_data.sh
>index a37a640..97114f2 100755
>--- a/tools/sample_data.sh
>+++ b/tools/sample_data.sh
>@@ -35,9 +35,6 @@
> # Works with Catalog SQL backend. Do not use with Catalog Templated backend
> # (default).
> #
>-# A set of EC2-compatible credentials is created for both admin and demo
>-# users and placed in etc/ec2rc.
>-#
> # Tenant               User      Roles
> # -------------------------------------------------------
> # admin                admin     admin
>@@ -246,20 +243,3 @@ if [[ -n "$ENABLE_QUANTUM" ]]; then
>     fi
> fi
> 
>-
>-# create ec2 creds and parse the secret and access key returned
>-RESULT=$(keystone ec2-credentials-create --tenant_id=$ADMIN_TENANT --user_id=$ADMIN_USER)
>-ADMIN_ACCESS=`echo "$RESULT" | grep access | awk '{print $4}'`
>-ADMIN_SECRET=`echo "$RESULT" | grep secret | awk '{print $4}'`
>-
>-RESULT=$(keystone ec2-credentials-create --tenant_id=$DEMO_TENANT --user_id=$DEMO_USER)
>-DEMO_ACCESS=`echo "$RESULT" | grep access | awk '{print $4}'`
>-DEMO_SECRET=`echo "$RESULT" | grep secret | awk '{print $4}'`
>-
>-# write the secret and access to ec2rc
>-cat > $EC2RC <<EOF
>-ADMIN_ACCESS=$ADMIN_ACCESS
>-ADMIN_SECRET=$ADMIN_SECRET
>-DEMO_ACCESS=$DEMO_ACCESS
>-DEMO_SECRET=$DEMO_SECRET
>-EOF
>-- 
>1.7.7.6
>

Flags:

apevec: review?

Actions: View | Diff

Attachments on bug 873447: 641626