Attachment 650555 Details for Bug 879016 – phpMemcachedAdmin-review.txt

phpMemcachedAdmin-review.txt

phpMemcachedAdmin-review.txt (text/plain), 9.65 KB, created by Remi Collet on 2012-11-23 17:11:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-11-23 17:11:41 UTC

Size: 9.65 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>==== ISSUES ====
>
>[!]: Requires correct, justified where necessary.
>	According to phpci result, should 
>
>	=> Requires: php-date
>
>[!]: typo
>	these informations => this information
>	some desc Â§ are don't ended with a .
>
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>
>	=> add link to upstream bug
>
>[!]: Package does not include license text
>
>	Common licenses that require including their texts with all derivative
>	works include ASL 2.0, EPL, BSD and MIT.
>
>	=> add the license
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[x]: %config files are marked noreplace or the reason is justified.
>[x]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[-]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[-]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Apache (v2.0)", "Unknown or generated". 2 files have unknown license.
>     Detailed output of licensecheck in
>     /home/extras/SPECS/review/879016-phpMemcachedAdmin/licensecheck.txt
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: No %config files under /usr.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[!]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[x]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 0 bytes in 0 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[!]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[x]: Package functions as described.
>[x]: Latest version is packaged.
>[!]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: Scriptlets must be sane, if used.
>[x]: SourceX tarball generation or download is documented.
>[x]: SourceX / PatchY prefixed with %{name}.
>[x]: SourceX is a working URL.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[-]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: phpMemcachedAdmin-1.2.2-3.svn262.fc17.noarch.rpm
>          phpMemcachedAdmin-1.2.2-3.svn262.fc17.src.rpm
>phpMemcachedAdmin.noarch: W: spelling-error Summary(en_US) memcached -> schemed
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US memcached -> schemed
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US decrement -> decrements, decremented, excrement
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US cas -> sac, cad, ca
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US googlecharts -> archaeologists
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US informations -> information, information's, in formations
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US phpMemcacheAdmin -> headmistress
>phpMemcachedAdmin.noarch: W: no-documentation
>phpMemcachedAdmin.src: W: spelling-error Summary(en_US) memcached -> schemed
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US memcached -> schemed
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US decrement -> decrements, decremented, excrement
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US cas -> sac, cad, ca
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US googlecharts -> archaeologists
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US informations -> information, information's, in formations
>phpMemcachedAdmin.src: W: spelling-error %description -l en_US phpMemcacheAdmin -> headmistress
>2 packages and 0 specfiles checked; 0 errors, 15 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint phpMemcachedAdmin
>phpMemcachedAdmin.noarch: W: spelling-error Summary(en_US) memcached -> schemed
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US memcached -> schemed
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US decrement -> decrements, decremented, excrement
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US cas -> sac, cad, ca
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US googlecharts -> archaeologists
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US informations -> information, information's, in formations
>phpMemcachedAdmin.noarch: W: spelling-error %description -l en_US phpMemcacheAdmin -> headmistress
>phpMemcachedAdmin.noarch: W: no-documentation
>1 packages and 0 specfiles checked; 0 errors, 8 warnings.
># echo 'rpmlint-done:'
>
>
>PHPCI
>-----
>
>-------------------------------------------------------------------------------
>  EXTENSION                             EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Core                                  4.0.0             4.0.0              18
>  date                                  0.0               4.0.0               6
>  standard                              4.1.0             4.0.0             180
>-------------------------------------------------------------------------------
>
>
>
>Requires
>--------
>phpMemcachedAdmin-1.2.2-3.svn262.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh  
>    /sbin/restorecon  
>    /sbin/service  
>    /usr/sbin/semanage  
>    config(phpMemcachedAdmin) = 1.2.2-3.svn262.fc17
>    httpd  
>    mod_php  
>    php-common >= 5.2.0
>
>
>
>Provides
>--------
>phpMemcachedAdmin-1.2.2-3.svn262.fc17.noarch.rpm:
>    
>    config(phpMemcachedAdmin) = 1.2.2-3.svn262.fc17
>    phpMemcachedAdmin = 1.2.2-3.svn262.fc17
>
>
>
>MD5-sum check
>-------------
>http://phpmemcacheadmin.googlecode.com/files/phpMemcachedAdmin-1.2.2-r262.tar.gz :
>  CHECKSUM(SHA256) this package     : 10022211593c78b4eaaec16054843979f0b98ed72e86ee93e4fe79bf35c383e3
>  CHECKSUM(SHA256) upstream package : 10022211593c78b4eaaec16054843979f0b98ed72e86ee93e4fe79bf35c383e3
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 879016

Actions: View

Attachments on bug 879016: 650555