Attachment 650714 Details for Bug 859504 – fedora-review results

fedora-review results

php-xcache-review.txt (text/plain), 9.69 KB, created by Johan Cwiklinski on 2012-11-23 23:11:29 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Johan Cwiklinski

Created: 2012-11-23 23:11:29 UTC

Size: 9.69 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>[!]: Package requires php-common instead of php.
>See: http://fedoraproject.org/wiki/Packaging:PHP
>[!]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>     Note: Upstream MD5sum check error, diff is in /home/builder/859504-php-
>     xcache/diff.txt
>See: http://fedoraproject.org/wiki/Packaging/SourceURL
>[!]: Package does not generate any conflict.
>     Note: Package contains Conflicts: tag(s) needing fix or justification.
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#Conflicts
>
>
>===== MUST items =====
>
>C/C++:
>[x]: Header files in -devel subpackage, if present.
>[x]: Package does not contain any libtool archives (.la)
>[ ]: Package does not contain kernel modules.
>[ ]: Package contains no static executables.
>[x]: Rpath absent or only used for internal libs.
>[ ]: Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.
>
>Generic:
>[ ]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[ ]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[ ]: Package contains no bundled libraries.
>[ ]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[ ]: Sources contain only permissible code or content.
>[x]: %config files are marked noreplace or the reason is justified.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[ ]: Macros in Summary, %description expandable at SRPM build time.
>[ ]: Package contains desktop file if it is a GUI application.
>[ ]: Development files must be in a -devel package
>[ ]: Package requires other packages for directories it uses.
>[ ]: Package uses nothing in %doc for runtime.
>[ ]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Fully versioned dependency in subpackages, if present.
>[ ]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[ ]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "Unknown or generated". 1 files have unknown license. Detailed output of
>     licensecheck in /home/builder/859504-php-xcache/licensecheck.txt
>[ ]: License file installed when any subpackage combination is installed.
>[ ]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[ ]: Package is named according to the Package Naming Guidelines.
>[x]: No %config files under /usr.
>[!]: Package does not generate any conflict.
>     Note: Package contains Conflicts: tag(s) needing fix or justification.
>[x]: Package do not use a name that already exist
>[ ]: Package obeys FHS, except libexecdir and /usr/target.
>[ ]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[ ]: Package must own all directories that it creates.
>[ ]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[ ]: Package is not relocatable.
>[ ]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[!]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>     Note: Upstream MD5sum check error, diff is in /home/builder/859504-php-
>     xcache/diff.txt
>[ ]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[ ]: Useful -debuginfo package or justification otherwise.
>[ ]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 20480 bytes in 5 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[!]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[ ]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: Package functions as described.
>[ ]: Latest version is packaged.
>[ ]: Package does not include license text files separate from upstream.
>[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Patch0 (xcache-config.patch) Source0 (xcache-3.0.0.tar.gz) Source1
>     (xcache-httpd.conf)
>[x]: SourceX is a working URL.
>[ ]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: %check is present and all tests pass.
>[ ]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: php-xcache-3.0.0-1.fc19.src.rpm
>          php-xcache-3.0.0-1.fc19.x86_64.rpm
>          php-xcache-debuginfo-3.0.0-1.fc19.x86_64.rpm
>php-xcache.src: W: spelling-error Summary(en_US) opcode -> op code, op-code, code
>php-xcache.src: W: spelling-error Summary(en_US) cacher -> cachet, cache, catcher
>php-xcache.src: W: spelling-error %description -l en_US opcode -> op code, op-code, code
>php-xcache.src: W: spelling-error %description -l en_US cacher -> cachet, cache, catcher
>php-xcache.src: W: spelling-error %description -l en_US linux -> Linux
>php-xcache.src: W: spelling-error %description -l en_US opcachers -> cowcatchers
>php-xcache.src: W: file-size-mismatch xcache-3.0.0.tar.gz = 162815, http://xcache.lighttpd.net/pub/Releases/3.0.0/xcache-3.0.0.tar.gz = 163216
>php-xcache.x86_64: W: spelling-error Summary(en_US) opcode -> op code, op-code, code
>php-xcache.x86_64: W: spelling-error Summary(en_US) cacher -> cachet, cache, catcher
>php-xcache.x86_64: W: spelling-error %description -l en_US opcode -> op code, op-code, code
>php-xcache.x86_64: W: spelling-error %description -l en_US cacher -> cachet, cache, catcher
>php-xcache.x86_64: W: spelling-error %description -l en_US linux -> Linux
>php-xcache.x86_64: W: spelling-error %description -l en_US opcachers -> cowcatchers
>3 packages and 0 specfiles checked; 0 errors, 13 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-xcache php-xcache-debuginfo
>php-xcache.x86_64: W: spelling-error Summary(en_US) opcode -> op code, op-code, code
>php-xcache.x86_64: W: spelling-error Summary(en_US) cacher -> cachet, cache, catcher
>php-xcache.x86_64: W: spelling-error %description -l en_US opcode -> op code, op-code, code
>php-xcache.x86_64: W: spelling-error %description -l en_US cacher -> cachet, cache, catcher
>php-xcache.x86_64: W: spelling-error %description -l en_US linux -> Linux
>php-xcache.x86_64: W: spelling-error %description -l en_US opcachers -> cowcatchers
>2 packages and 0 specfiles checked; 0 errors, 6 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-xcache-3.0.0-1.fc19.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>    libc.so.6()(64bit)  
>    php(api) = 20100412-x86-64
>    php(zend-abi) = 20100525-x86-64
>    rtld(GNU_HASH)  
>
>php-xcache-debuginfo-3.0.0-1.fc19.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>
>
>
>Provides
>--------
>php-xcache-3.0.0-1.fc19.x86_64.rpm:
>    
>    php-xcache = 3.0.0-1.fc19
>    php-xcache(x86-64) = 3.0.0-1.fc19
>
>php-xcache-debuginfo-3.0.0-1.fc19.x86_64.rpm:
>    
>    php-xcache-debuginfo = 3.0.0-1.fc19
>    php-xcache-debuginfo(x86-64) = 3.0.0-1.fc19
>
>
>
>Unversioned so-files
>--------------------
>php-xcache-3.0.0-1.fc19.x86_64.rpm: /usr/lib64/php-zts/modules/xcache.so
>php-xcache-3.0.0-1.fc19.x86_64.rpm: /usr/lib64/php/modules/xcache.so
>
>MD5-sum check
>-------------
>http://xcache.lighttpd.net/pub/Releases/3.0.0/xcache-3.0.0.tar.gz :
>  CHECKSUM(SHA256) this package     : 36fd797d63dd5486595bcce425a3b42eba4fb93beddca2b6adb539d0440c5de1
>  CHECKSUM(SHA256) upstream package : a2221146018a666d1746b23c6e2a743fcd447c2e6a5fe00f1b713b77010897d3
>diff -r also reports differences
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-rawhide-x86_64
>Command line :/usr/bin/fedora-review -b 859504 -m fedora-rawhide-x86_64

Actions: View

Attachments on bug 859504: 650714 | 650715