Attachment 650886 Details for Bug 873643 – fedora-review results

fedora-review results

php-pecl-uuid-review.txt (text/plain), 10.08 KB, created by Johan Cwiklinski on 2012-11-24 09:28:03 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Johan Cwiklinski

Created: 2012-11-24 09:28:03 UTC

Size: 10.08 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>
>Issues:
>=======
>[!]: Package requires php-common instead of php.
>See: http://fedoraproject.org/wiki/Packaging:PHP
>[!]: Package does not generate any conflict.
>     Note: Package contains Conflicts: tag(s) needing fix or justification.
>See: http://fedoraproject.org/wiki/Packaging/Guidelines#Conflicts
>
>
>===== MUST items =====
>
>C/C++:
>[x]: Header files in -devel subpackage, if present.
>[x]: Package does not contain any libtool archives (.la)
>[ ]: Package does not contain kernel modules.
>[ ]: Package contains no static executables.
>[x]: Rpath absent or only used for internal libs.
>[ ]: Development (unversioned) .so files in -devel subpackage, if present.
>     Note: Unversioned so-files in private %_libdir subdirectory (see
>     attachment). Verify they are not in ld path.
>
>Generic:
>[ ]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[ ]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[ ]: Package contains no bundled libraries.
>[ ]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>[ ]: Sources contain only permissible code or content.
>[x]: %config files are marked noreplace or the reason is justified.
>[x]: Each %files section contains %defattr if rpm < 4.4
>[ ]: Macros in Summary, %description expandable at SRPM build time.
>[ ]: Package contains desktop file if it is a GUI application.
>[ ]: Development files must be in a -devel package
>[ ]: Package requires other packages for directories it uses.
>[ ]: Package uses nothing in %doc for runtime.
>[ ]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[ ]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[ ]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[ ]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "*No copyright* LGPL (v2.1 or later) (with incorrect FSF address)". 1
>     files have unknown license. Detailed output of licensecheck in
>     /home/builder/873643-php-pecl-uuid/licensecheck.txt
>[ ]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[ ]: Package is named according to the Package Naming Guidelines.
>[x]: No %config files under /usr.
>[!]: Package does not generate any conflict.
>     Note: Package contains Conflicts: tag(s) needing fix or justification.
>[x]: Package do not use a name that already exist
>[ ]: Package obeys FHS, except libexecdir and /usr/target.
>[ ]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[ ]: Package must own all directories that it creates.
>[ ]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[ ]: Package is not relocatable.
>[ ]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[ ]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[ ]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[ ]: Useful -debuginfo package or justification otherwise.
>[ ]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 10240 bytes in 1 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[!]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>[ ]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[ ]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[ ]: Package functions as described.
>[ ]: Latest version is packaged.
>[ ]: Package does not include license text files separate from upstream.
>[ ]: Patches link to upstream bugs/comments/lists or are otherwise justified.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[ ]: Scriptlets must be sane, if used.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Patch0 (uuid-ereg.patch) Patch1 (uuid-build.patch) Source0
>     (uuid-1.0.3.tgz) Patch2 (uuid-info.patch)
>[x]: SourceX is a working URL.
>[ ]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[ ]: Package should compile and build into binary rpms on all supported
>     architectures.
>[ ]: %check is present and all tests pass.
>[ ]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[!]: Spec file according to URL is the same as in SRPM.
>     Note: Spec file as given by url is not the same as in SRPM (see attached
>     diff).
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: php-pecl-uuid-1.0.3-2.fc19.src.rpm
>          php-pecl-uuid-1.0.3-2.fc19.x86_64.rpm
>          php-pecl-uuid-debuginfo-1.0.3-2.fc19.x86_64.rpm
>php-pecl-uuid.src: W: spelling-error %description -l en_US libuuid -> liquid
>php-pecl-uuid.src:42: W: unversioned-explicit-obsoletes php53-pecl-%{pecl_name}
>php-pecl-uuid.src:43: W: unversioned-explicit-obsoletes php53u-pecl-%{pecl_name}
>php-pecl-uuid.src:45: W: unversioned-explicit-obsoletes php54-pecl-%{pecl_name}
>php-pecl-uuid.x86_64: W: spelling-error %description -l en_US libuuid -> liquid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php53-pecl-uuid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php53u-pecl-uuid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php54-pecl-uuid
>3 packages and 0 specfiles checked; 0 errors, 8 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-pecl-uuid-debuginfo php-pecl-uuid
>php-pecl-uuid.x86_64: W: spelling-error %description -l en_US libuuid -> liquid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php53-pecl-uuid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php53u-pecl-uuid
>php-pecl-uuid.x86_64: W: obsolete-not-provided php54-pecl-uuid
>2 packages and 0 specfiles checked; 0 errors, 4 warnings.
># echo 'rpmlint-done:'
>
>
>
>Diff spec file in url and in SRPM
>---------------------------------
>--- /home/builder/873643-php-pecl-uuid/srpm/php-pecl-uuid.spec	2012-11-24 09:52:05.299537472 +0100
>+++ /home/builder/873643-php-pecl-uuid/srpm-unpacked/php-pecl-uuid.spec	2012-11-24 09:52:06.004538056 +0100
>@@ -24,4 +24,5 @@
> Patch2:        %{pecl_name}-info.patch
> 
>+BuildRoot:     %{_tmppath}/%{name}-%{version}-%{release}-root
> BuildRequires: php-devel
> BuildRequires: php-pear
>@@ -38,4 +39,12 @@
> Provides:      php-pecl(%{pecl_name})%{?_isa} = %{version}
> 
>+# Other third party repo stuff
>+Obsoletes:     php53-pecl-%{pecl_name}
>+Obsoletes:     php53u-pecl-%{pecl_name}
>+%if "%{php_version}" > "5.4"
>+Obsoletes:     php54-pecl-%{pecl_name}
>+%endif
>+
>+
> # Filter private shared
> %{?filter_provides_in: %filter_provides_in %{_libdir}/.*\.so$}
>@@ -92,4 +101,5 @@
> 
> %install
>+rm -rf %{buildroot}
> # Install the NTS stuff
> make -C %{pecl_name}-%{version} install INSTALL_ROOT=%{buildroot}
>@@ -136,5 +146,10 @@
> 
> 
>+%clean
>+rm -rf %{buildroot}
>+
>+
> %files
>+%defattr(-, root, root, 0755)
> %doc %{pecl_name}-%{version}/CREDITS
> %{pecl_xmldir}/%{name}.xml
>@@ -152,5 +167,4 @@
> * Tue Nov  6 2012 Remi Collet <remi@fedoraproject.org> - 1.0.3-2
> - more upstream patches (build warning + phpinfo output)
>-- cleanups for review
> 
> * Tue Nov  6 2012 Remi Collet <remi@fedoraproject.org> - 1.0.3-1
>
>
>Requires
>--------
>php-pecl-uuid-1.0.3-2.fc19.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>    /bin/sh  
>    /usr/bin/pecl  
>    libc.so.6()(64bit)  
>    libuuid.so.1()(64bit)  
>    libuuid.so.1(UUID_1.0)(64bit)  
>    php(api) = 20100412-x86-64
>    php(zend-abi) = 20100525-x86-64
>    rtld(GNU_HASH)  
>
>php-pecl-uuid-debuginfo-1.0.3-2.fc19.x86_64.rpm (rpmlib, GLIBC filtered):
>    
>
>
>
>Provides
>--------
>php-pecl-uuid-1.0.3-2.fc19.x86_64.rpm:
>    
>    php-pecl(uuid) = 1.0.3
>    php-pecl(uuid)(x86-64) = 1.0.3
>    php-pecl-uuid = 1.0.3-2.fc19
>    php-pecl-uuid(x86-64) = 1.0.3-2.fc19
>
>php-pecl-uuid-debuginfo-1.0.3-2.fc19.x86_64.rpm:
>    
>    php-pecl-uuid-debuginfo = 1.0.3-2.fc19
>    php-pecl-uuid-debuginfo(x86-64) = 1.0.3-2.fc19
>
>
>
>Unversioned so-files
>--------------------
>php-pecl-uuid-1.0.3-2.fc19.x86_64.rpm: /usr/lib64/php-zts/modules/uuid.so
>php-pecl-uuid-1.0.3-2.fc19.x86_64.rpm: /usr/lib64/php/modules/uuid.so
>
>MD5-sum check
>-------------
>http://pecl.php.net/get/uuid-1.0.3.tgz :
>  CHECKSUM(SHA256) this package     : 6832c6453efec9800d2dc0bb9786cea02888378e88c15851f79210ef78369ef1
>  CHECKSUM(SHA256) upstream package : 6832c6453efec9800d2dc0bb9786cea02888378e88c15851f79210ef78369ef1
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-rawhide-x86_64
>Command line :/usr/bin/fedora-review -b 873643 -m fedora-rawhide-x86_64

Actions: View

Attachments on bug 873643: 650886