Attachment 651409 Details for Bug 879397 – php-Slim-review.txt

php-Slim-review.txt

php-Slim-review.txt (text/plain), 9.06 KB, created by Remi Collet on 2012-11-25 07:57:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Remi Collet

Created: 2012-11-25 07:57:00 UTC

Size: 9.06 KB

patch

obsolete

>
>Package Review
>==============
>
>Key:
>[x] = Pass
>[!] = Fail
>[-] = Not applicable
>[?] = Not evaluated
>[ ] = Manual review needed
>
>===== ISSUES =====
>
>* Move phpunit.xml.dist to tests subpackage (probably not in %doc)
>
>* From PHPCI result, must also requires 
>
>	php-spl, php-simplexml, php-date, php-hash, php-json, 
>	php-mbstring, php-pcre, php-session
>
>    From PHP Guidelines : 
>
>	PHP extensions must have a Requires on all of the dependent extensions
>	(php-date, php-gd, php-mbstring, ...). These extensions are virtual
>	Provides of the php sub-packages. 
>
>* Files placement
>
>	Why /usr/share/php/Slim/Slim ?
>	Why not simply /usr/share/php/Slim
>
>	As /usr/share/php is in the standard include_path, 
>	require 'Slim/Slim.php'; will work
>
>	Why /usr/share/tests/Slim/tests
>	Why not simply /usr/share/tests/Slim
>
>
>===== MUST items =====
>
>Generic:
>[x]: Package is licensed with an open-source compatible license and meets
>     other legal requirements as defined in the legal section of Packaging
>     Guidelines.
>[x]: Package successfully compiles and builds into binary rpms on at least one
>     supported primary architecture.
>[-]: %build honors applicable compiler flags or justifies otherwise.
>[x]: All build dependencies are listed in BuildRequires, except for any that
>     are listed in the exceptions section of Packaging Guidelines.
>[x]: Package contains no bundled libraries.
>[x]: Changelog in prescribed format.
>[x]: Package does not run rm -rf %{buildroot} (or $RPM_BUILD_ROOT) at the
>     beginning of %install.
>     Note: rm -rf %{buildroot} present but not required
>[x]: Sources contain only permissible code or content.
>[x]: Each %files section contains %defattr if rpm < 4.4
>     Note: %defattr present but not needed
>[x]: Macros in Summary, %description expandable at SRPM build time.
>[-]: Package contains desktop file if it is a GUI application.
>[-]: Development files must be in a -devel package
>[x]: Package requires other packages for directories it uses.
>[x]: Package uses nothing in %doc for runtime.
>[x]: Package is not known to require ExcludeArch.
>[x]: Package does not contain duplicates in %files.
>[x]: Permissions on files are set properly.
>[x]: Fully versioned dependency in subpackages, if present.
>[x]: Package complies to the Packaging Guidelines
>[x]: Spec file lacks Packager, Vendor, PreReq tags.
>[x]: If (and only if) the source package includes the text of the license(s)
>     in its own file, then that file, containing the text of the license(s)
>     for the package is included in %doc.
>[x]: License field in the package spec file matches the actual license.
>     Note: Checking patched sources after %prep for licenses. Licenses found:
>     "MIT/X11 (BSD like)", "Unknown or generated". 2 files have unknown
>     license. Detailed output of licensecheck in
>     /home/extras/SPECS/review/879397-php-Slim/licensecheck.txt
>[x]: License file installed when any subpackage combination is installed.
>[x]: Package consistently uses macro is (instead of hard-coded directory
>     names).
>[x]: Package is named using only allowed ASCII characters.
>[x]: Package is named according to the Package Naming Guidelines.
>[x]: Package does not generate any conflict.
>     Note: Package contains no Conflicts: tag(s)
>[x]: Package do not use a name that already exist
>[x]: Package obeys FHS, except libexecdir and /usr/target.
>[-]: If the package is a rename of another package, proper Obsoletes and
>     Provides are present.
>[x]: Package must own all directories that it creates.
>[x]: Package does not own files or directories owned by other packages.
>[x]: Package installs properly.
>[x]: Package is not relocatable.
>[x]: Requires correct, justified where necessary.
>[x]: CheckResultdir
>[x]: Rpmlint is run on all rpms the build produces.
>     Note: There are rpmlint messages (see attachment).
>[x]: Sources used to build the package match the upstream source, as provided
>     in the spec URL.
>[x]: Spec file is legible and written in American English.
>[x]: Spec file name must match the spec package %{name}, in the format
>     %{name}.spec.
>[-]: Package contains systemd file(s) if in need.
>[x]: File names are valid UTF-8.
>[-]: Large documentation must go in a -doc subpackage.
>     Note: Documentation size is 40960 bytes in 6 files.
>[x]: Packages must not store files under /srv, /opt or /usr/local
>
>PHP:
>[x]: Package requires php-common instead of php.
>
>===== SHOULD items =====
>
>Generic:
>[x]: Reviewer should test that the package builds in mock.
>[x]: Buildroot is not present
>     Note: Buildroot: present but not needed
>[x]: Package has no %clean section with rm -rf %{buildroot} (or
>     $RPM_BUILD_ROOT)
>     Note: %clean present but not required
>[-]: If the source package does not include license text(s) as a separate file
>     from upstream, the packager SHOULD query upstream to include it.
>[x]: Dist tag is present.
>[x]: No file requires outside of /etc, /bin, /sbin, /usr/bin, /usr/sbin.
>[x]: Final provides and requires are sane (rpm -q --provides and rpm -q
>     --requires).
>[?]: Package functions as described.
>[x]: Latest version is packaged.
>[x]: Package does not include license text files separate from upstream.
>[x]: The placement of pkgconfig(.pc) files are correct.
>[x]: SourceX tarball generation or download is documented.
>[!]: SourceX / PatchY prefixed with %{name}.
>     Note: Source0 (2.1.0.tar.gz)
>[x]: SourceX is a working URL.
>[-]: Description and summary sections in the package spec file contains
>     translations for supported Non-English languages, if available.
>[x]: Package should compile and build into binary rpms on all supported
>     architectures.
>[x]: %check is present and all tests pass.
>[x]: Packages should try to preserve timestamps of original installed files.
>[x]: Spec use %global instead of %define.
>
>===== EXTRA items =====
>
>Generic:
>[x]: Rpmlint is run on all installed packages.
>     Note: There are rpmlint messages (see attachment).
>[x]: Spec file according to URL is the same as in SRPM.
>[x]: Large data in /usr/share should live in a noarch subpackage if package is
>     arched.
>
>
>Rpmlint
>-------
>Checking: php-Slim-2.1.0-2.fc17.noarch.rpm
>          php-Slim-tests-2.1.0-2.fc17.noarch.rpm
>          php-Slim-2.1.0-2.fc17.src.rpm
>php-Slim.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
>php-Slim.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
>php-Slim.src: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
>php-Slim.src: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
>3 packages and 0 specfiles checked; 0 errors, 4 warnings.
>
>
>
>
>Rpmlint (installed packages)
>----------------------------
># rpmlint php-Slim-tests php-Slim
>php-Slim.noarch: W: spelling-error %description -l en_US wildcards -> wild cards, wild-cards, wildcatters
>php-Slim.noarch: W: spelling-error %description -l en_US middleware -> middle ware, middle-ware, middleweight
>2 packages and 0 specfiles checked; 0 errors, 2 warnings.
># echo 'rpmlint-done:'
>
>
>
>Requires
>--------
>php-Slim-2.1.0-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-common >= 5.3.0
>    php-mcrypt  
>
>php-Slim-tests-2.1.0-2.fc17.noarch.rpm (rpmlib, GLIBC filtered):
>    
>    php-Slim = 2.1.0-2.fc17
>    php-pear(PEAR)  
>
>
>PHPCI
>-----
>-------------------------------------------------------------------------------
>PHP COMPAT INFO EXTENSION SUMMARY
>-------------------------------------------------------------------------------
>  EXTENSION                             EXT min/Max       PHP min/Max     COUNT
>-------------------------------------------------------------------------------
>  Core                                  4.0.0             4.0.0             144
>  SPL                                   5.0.0             5.0.0              33
>  SimpleXML                             0.0               5.0.0               1
>  date                                  0.0               4.0.0              12
>  hash                                  1.1               4.0.0               6
>  json                                  5.2.0             5.2.0               1
>  mbstring                              0.0               4.0.6               1
>C mcrypt                                0.0               4.0.0              22
>  pcre                                  0.0               4.0.0              11
>  session                               0.0               4.0.0               5
>  standard                              4.3.0             4.0.0             285
>-------------------------------------------------------------------------------
>
>
>Provides
>--------
>php-Slim-2.1.0-2.fc17.noarch.rpm:
>    
>    php-Slim = 2.1.0-2.fc17
>
>php-Slim-tests-2.1.0-2.fc17.noarch.rpm:
>    
>    php-Slim-tests = 2.1.0-2.fc17
>
>
>
>MD5-sum check
>-------------
>https://github.com/codeguy/Slim/archive/2.1.0.tar.gz :
>  CHECKSUM(SHA256) this package     : ab89a1d8124f5220810c96c9fd4445d0c7b7594e87d49ef8faf28a99948f7fdf
>  CHECKSUM(SHA256) upstream package : ab89a1d8124f5220810c96c9fd4445d0c7b7594e87d49ef8faf28a99948f7fdf
>
>
>Generated by fedora-review 0.3.1 (b71abc1) last change: 2012-10-16
>Buildroot used: fedora-17-x86_64
>Command line :/usr/bin/fedora-review -b 879397

Flags:

fedora: review?

Actions: View

Attachments on bug 879397: 651409