Attachment 652003 Details for Bug 880260 – Proposed patch

[patch] Proposed patch

0001-mcompand-fix-bad-clipping-due-to-overflow-of-band-su.patch (text/plain), 1.01 KB, created by Guido Aulisi on 2012-11-26 15:17:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Guido Aulisi

Created: 2012-11-26 15:17:19 UTC

Size: 1.01 KB

patch

obsolete

>From 501e8555470ccd8f88c005b4e078f19f67ccafba Mon Sep 17 00:00:00 2001
>From: Guido Aulisi <guido.aulisi@gmail.com>
>Date: Mon, 26 Nov 2012 15:38:07 +0100
>Subject: [PATCH] mcompand: fix bad clipping due to overflow of band summing.
>
>When summing bands in mcompand I got some bad unnoticed clipping,
>and the samples wrapped from positive to negative and viceversa.
>With many bands sox_sample_t intergers get wrapped before being cast
>to double.
>---
> src/mcompand.c | 2 +-
> 1 file modificato, 1 inserzione(+). 1 rimozione(-)
>
>diff --git a/src/mcompand.c b/src/mcompand.c
>index ce5dc0b..8add94b 100644
>--- a/src/mcompand.c
>+++ b/src/mcompand.c
>@@ -390,7 +390,7 @@ static int flow(sox_effect_t * effp, const sox_sample_t *ibuf, sox_sample_t *obu
>     (void)sox_mcompand_flow_1(effp, c,l,bbuf,abuf,len, (size_t)effp->out_signal.channels);
>     for (i=0;i<len;++i)
>     {
>-      out = obuf[i] + abuf[i];
>+      out = (double)obuf[i] + (double)abuf[i];
>       SOX_SAMPLE_CLIP_COUNT(out, effp->clips);
>       obuf[i] = out;
>     }
>-- 
>1.7.11.7
>

Actions: View | Diff

Attachments on bug 880260: 652003