Attachment 652561 Details for Bug 880381 – Patch fixing this crash

[patch] Patch fixing this crash

0001-Add-patch-fixing-rhbz-880381.patch (text/plain), 2.77 KB, created by Christophe Fergeau on 2012-11-27 09:32:48 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Christophe Fergeau

Created: 2012-11-27 09:32:48 UTC

Size: 2.77 KB

patch

obsolete

>From 210b66d276eda56caa378c876220589a7f5a34f7 Mon Sep 17 00:00:00 2001
>From: Christophe Fergeau <cfergeau@redhat.com>
>Date: Tue, 27 Nov 2012 10:27:02 +0100
>Subject: [PATCH] Add patch fixing rhbz#880381
>
>---
> 0001-Don-t-free-SPICE-ticket-twice.patch | 28 ++++++++++++++++++++++++++++
> virt-viewer.spec                         |  8 +++++++-
> 2 files changed, 35 insertions(+), 1 deletion(-)
> create mode 100644 0001-Don-t-free-SPICE-ticket-twice.patch
>
>diff --git a/0001-Don-t-free-SPICE-ticket-twice.patch b/0001-Don-t-free-SPICE-ticket-twice.patch
>new file mode 100644
>index 0000000..d5d4892
>--- /dev/null
>+++ b/0001-Don-t-free-SPICE-ticket-twice.patch
>@@ -0,0 +1,28 @@
>+From a4e588e3eacf4e5590ff98171a495f8fa0e37375 Mon Sep 17 00:00:00 2001
>+From: Christophe Fergeau <cfergeau@redhat.com>
>+Date: Mon, 1 Oct 2012 18:22:04 +0200
>+Subject: [virt-viewer] Don't free SPICE ticket twice
>+
>+Commit 2201a5a was supposed to free a SPICE ticket leak, but it's
>+actually introducing a double-free as the SPICE ticket is
>+unconditionally freed at the end of
>+virt_viewer_session_spice_main_channel_event
>+---
>+ src/virt-viewer-session-spice.c | 1 -
>+ 1 file changed, 1 deletion(-)
>+
>+diff --git a/src/virt-viewer-session-spice.c b/src/virt-viewer-session-spice.c
>+index 5fcd7fb..2577f2b 100644
>+--- a/src/virt-viewer-session-spice.c
>++++ b/src/virt-viewer-session-spice.c
>+@@ -326,7 +326,6 @@ virt_viewer_session_spice_main_channel_event(SpiceChannel *channel G_GNUC_UNUSED
>+             gboolean openfd;
>+ 
>+             g_object_set(self->priv->session, "password", password, NULL);
>+-            g_free(password);
>+             g_object_get(self->priv->session, "client-sockets", &openfd, NULL);
>+ 
>+             if (openfd)
>+-- 
>+1.8.0
>+
>diff --git a/virt-viewer.spec b/virt-viewer.spec
>index c769ba1..978ea3f 100644
>--- a/virt-viewer.spec
>+++ b/virt-viewer.spec
>@@ -25,12 +25,13 @@
> 
> Name: virt-viewer
> Version: 0.5.4
>-Release: 2%{?dist}%{?extra_release}
>+Release: 3%{?dist}%{?extra_release}
> Summary: Virtual Machine Viewer
> Group: Applications/System
> License: GPLv2+
> URL: http://virt-manager.org/
> Source0: http://virt-manager.org/download/sources/%{name}/%{name}-%{version}.tar.gz
>+Patch1: 0001-Don-t-free-SPICE-ticket-twice.patch
> BuildRoot: %{_tmppath}/%{name}-%{version}-%{release}-root-%(%{__id_u} -n)
> Requires: openssh-clients
> Requires(post):   %{_sbindir}/update-alternatives
>@@ -91,6 +92,7 @@ browsers.
> 
> %prep
> %setup -q
>+%patch1 -p1
> 
> %build
> 
>@@ -172,6 +174,10 @@ update-desktop-database -q %{_datadir}/applications
> %endif
> 
> %changelog
>+* Tue Nov 27 2012 Christophe Fergeau <cfergeau@redhat.com> - 0.5.4-3
>+- Add patch fixing a double free on password-protected SPICE connections.
>+  Fixes rhbz#880381
>+
> * Sat Oct 13 2012 Chris Tyler <chris@tylers.info> - 0.5.4-2
> - Enabled spice support for ARM archs
> 
>-- 
>1.8.0
>

Actions: View | Diff

Attachments on bug 880381: 652561