Login
[x]
Log in using an account from:
Fedora Account System
Red Hat Associate
Red Hat Customer
Or login using a Red Hat Bugzilla account
Forgot Password
Login:
Hide Forgot
Create an Account
Red Hat Bugzilla – Attachment 657636 Details for
Bug 720644
[PATCH] large string repeat count causes heap corruption
[?]
New
Simple Search
Advanced Search
My Links
Browse
Requests
Reports
Current State
Search
Tabular reports
Graphical reports
Duplicates
Other Reports
User Changes
Plotly Reports
Bug Status
Bug Severity
Non-Defaults
|
Product Dashboard
Help
Page Help!
Bug Writing Guidelines
What's new
Browser Support Policy
5.0.4.rh83 Release notes
FAQ
Guides index
User guide
Web Services
Contact
Legal
This site requires JavaScript to be enabled to function correctly, please enable it.
[patch]
Fix case of 2^32±1 repeat counter.
0001-Do-not-wrap-number-of-bytes-to-copy-silently.patch (text/plain), 905 bytes, created by
Petr Pisar
on 2012-12-04 16:36:06 UTC
(
hide
)
Description:
Fix case of 2^32±1 repeat counter.
Filename:
MIME Type:
Creator:
Petr Pisar
Created:
2012-12-04 16:36:06 UTC
Size:
905 bytes
patch
obsolete
>From c08f4e55737a3e905b5a30f9eb72d4f8beaa292e Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Petr=20P=C3=ADsa=C5=99?= <ppisar@redhat.com> >Date: Tue, 4 Dec 2012 17:30:17 +0100 >Subject: [PATCH] Do not wrap number of bytes to copy silently > >32-bit x86 architecture has IV_MAX 2 less than I32_MAX. This allows to >initialize less bytes than requested (repeat counter 2^32-1..2^32+1 is >affected). This patch changes the silent wrap to noisy croak. > >See <https://bugzilla.redhat.com/show_bug.cgi?id=720644>. >--- > pp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/pp.c b/pp.c >index 28bbfe8..460e410 100644 >--- a/pp.c >+++ b/pp.c >@@ -1490,7 +1490,7 @@ PP(pp_repeat) > if (SvUOK(sv)) { > const UV uv = SvUV(sv); > if (uv > IV_MAX) >- count = IV_MAX; /* The best we can do? */ >+ Perl_croak_nocontext("%s", PL_memory_wrap); > else > count = uv; > } else { >-- >1.7.11.7 >
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=657636">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
Attachments on
bug 720644
:
625851
| 657636